leandrof/linux
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

ASoC: wm0010: fix memory leak

Browse Source 
We were aborting if the kzalloc of img_swap fails but without freeing the
already allocated out. Similarly we were aborting if spi_sync fails
without releasing out and img_swap.

Signed-off-by: Sudip Mukherjee <sudip@vectorindia.org>
Acked-by: Charles Keepax <ckeepax@opensource.wolfsonmicro.com>
Signed-off-by: Mark Brown <broonie@kernel.org>
This commit is contained in:
Sudip Mukherjee 2015-09-01 11:14:05 +05:30 committed by Mark Brown
parent bc0195aad0
commit 51d2eeef1d
1 changed files with 7 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
sound/soc/codecs/wm0010.c
View File

@ -672,8 +672,10 @@ static int wm0010_boot(struct snd_soc_codec *codec)
} }
img_swap = kzalloc(len, GFP_KERNEL | GFP_DMA); img_swap = kzalloc(len, GFP_KERNEL | GFP_DMA);
if (!img_swap) if (!img_swap) {
kfree(out);
goto abort; goto abort;
}
/* We need to re-order for 0010 */ /* We need to re-order for 0010 */
byte_swap_64((u64 *)&pll_rec, img_swap, len); byte_swap_64((u64 *)&pll_rec, img_swap, len);
@ -690,6 +692,8 @@ static int wm0010_boot(struct snd_soc_codec *codec)
ret = spi_sync(spi, &m); ret = spi_sync(spi, &m);
if (ret != 0) { if (ret != 0) {
dev_err(codec->dev, "First PLL write failed: %d\n", ret); dev_err(codec->dev, "First PLL write failed: %d\n", ret);
kfree(img_swap);
kfree(out);
goto abort; goto abort;
} }
@ -697,6 +701,8 @@ static int wm0010_boot(struct snd_soc_codec *codec)
ret = spi_sync(spi, &m); ret = spi_sync(spi, &m);
if (ret != 0) { if (ret != 0) {
dev_err(codec->dev, "Second PLL write failed: %d\n", ret); dev_err(codec->dev, "Second PLL write failed: %d\n", ret);
kfree(img_swap);
kfree(out);
goto abort; goto abort;
} }