leandrof/linux
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

ACPI: ec: Drop udelay() from poll mode. Loop by reading status field instead.

Browse Source 
Signed-off-by: Len Brown <len.brown@intel.com>
This commit is contained in:
Alexey Starikovskiy
2006-12-07 18:42:17 +03:00
committed by Len Brown
parent a86e277259
commit 50c1e1138c
1 changed files with 2 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
drivers/acpi/ec.c
View File

@@ -70,8 +70,6 @@ enum {
#define ACPI_EC_DELAY 500 /* Wait 500ms max. during EC ops */ #define ACPI_EC_DELAY 500 /* Wait 500ms max. during EC ops */
#define ACPI_EC_UDELAY_GLK 1000 /* Wait 1ms max. to get global lock */ #define ACPI_EC_UDELAY_GLK 1000 /* Wait 1ms max. to get global lock */
#define ACPI_EC_UDELAY 100 /* Poll @ 100us increments */
#define ACPI_EC_UDELAY_COUNT 1000 /* Wait 100ms max. during EC ops */
enum { enum {
EC_INTR = 1, /* Output buffer full */ EC_INTR = 1, /* Output buffer full */
@@ -159,11 +157,10 @@ static int acpi_ec_check_status(struct acpi_ec *ec, u8 event)
static int acpi_ec_wait(struct acpi_ec *ec, u8 event) static int acpi_ec_wait(struct acpi_ec *ec, u8 event)
{ {
if (acpi_ec_mode == EC_POLL) { if (acpi_ec_mode == EC_POLL) {
int i; unsigned long delay = jiffies + msecs_to_jiffies(ACPI_EC_DELAY);
for (i = 0; i < ACPI_EC_UDELAY_COUNT; ++i) { while (time_before(jiffies, delay)) {
if (acpi_ec_check_status(ec, event)) if (acpi_ec_check_status(ec, event))
return 0; return 0;
udelay(ACPI_EC_UDELAY);
} }
} else { } else {
if (wait_event_timeout(ec->wait, if (wait_event_timeout(ec->wait,