leandrof/linux
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

test_printf: Append strings more efficiently

Browse Source 
Use scnprintf instead of snprintf + strlen.

Signed-off-by: Matthew Wilcox (Oracle) <willy@infradead.org>
Reviewed-by: Petr Mladek <pmladek@suse.com>
Reviewed-by: Yafang Shao <laoar.shao@gmail.com>
Signed-off-by: Petr Mladek <pmladek@suse.com>
Link: https://lore.kernel.org/r/20211019142621.2810043-5-willy@infradead.org
This commit is contained in:
Matthew Wilcox (Oracle)
2021-10-19 15:26:20 +01:00
committed by Petr Mladek
parent 5b358b0de9
commit 507f986036
1 changed files with 7 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
lib/test_printf.c
View File

@@ -614,8 +614,7 @@ page_flags_test(int section, int node, int zone, int last_cpupid,
int i; int i;
if (flags & PAGEFLAGS_MASK) { if (flags & PAGEFLAGS_MASK) {
snprintf(cmp_buf + size, BUF_SIZE - size, "%s", name); size += scnprintf(cmp_buf + size, BUF_SIZE - size, "%s", name);
size = strlen(cmp_buf);
append = true; append = true;
} }
@@ -623,17 +622,14 @@ page_flags_test(int section, int node, int zone, int last_cpupid,
if (!pft[i].width) if (!pft[i].width)
continue; continue;
if (append) { if (append)
snprintf(cmp_buf + size, BUF_SIZE - size, "|"); size += scnprintf(cmp_buf + size, BUF_SIZE - size, "|");
size = strlen(cmp_buf);
}
flags |= (values[i] & pft[i].mask) << pft[i].shift; flags |= (values[i] & pft[i].mask) << pft[i].shift;
snprintf(cmp_buf + size, BUF_SIZE - size, "%s=", pft[i].name); size += scnprintf(cmp_buf + size, BUF_SIZE - size, "%s=",
size = strlen(cmp_buf); pft[i].name);
snprintf(cmp_buf + size, BUF_SIZE - size, pft[i].fmt, size += scnprintf(cmp_buf + size, BUF_SIZE - size, pft[i].fmt,
values[i] & pft[i].mask); values[i] & pft[i].mask);
size = strlen(cmp_buf);
append = true; append = true;
} }