leandrof/linux
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

serial: fsl_lpuart: Remove unnecessary clearing for CRTSCTS

Browse Source 
if (termios->c_cflag & CRTSCTS) guarantees that CRTSCTS is not ever set
in the else block so clearing it is unnecessary.

While at it, remove also one pair of extra parenthesis.

Reviewed-by: Johan Hovold <johan@kernel.org>
Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
Link: https://lore.kernel.org/r/20220513082906.11096-5-ilpo.jarvinen@linux.intel.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
Ilpo Järvinen 2022-05-13 11:29:05 +03:00 committed by Greg Kroah-Hartman
parent 9cca25e276
commit 503f418b10
1 changed files with 3 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
drivers/tty/serial/fsl_lpuart.c
View File

@ -2110,12 +2110,10 @@ lpuart32_set_termios(struct uart_port *port, struct ktermios *termios,
if (sport->port.rs485.flags & SER_RS485_ENABLED) if (sport->port.rs485.flags & SER_RS485_ENABLED)
termios->c_cflag &= ~CRTSCTS; termios->c_cflag &= ~CRTSCTS;
if (termios->c_cflag & CRTSCTS) { if (termios->c_cflag & CRTSCTS)
modem |= (UARTMODIR_RXRTSE | UARTMODIR_TXCTSE); modem |= UARTMODIR_RXRTSE | UARTMODIR_TXCTSE;
} else { else
termios->c_cflag &= ~CRTSCTS;
modem &= ~(UARTMODIR_RXRTSE | UARTMODIR_TXCTSE); modem &= ~(UARTMODIR_RXRTSE | UARTMODIR_TXCTSE);
}
if (termios->c_cflag & CSTOPB) if (termios->c_cflag & CSTOPB)
bd |= UARTBAUD_SBNS; bd |= UARTBAUD_SBNS;