leandrof/linux
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Input: gpio-keys - switch to bitmap_zalloc()

Browse Source 
Switch to bitmap_zalloc() to show clearly what we are allocating.
Besides that it returns pointer of bitmap type instead of opaque void *.

Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
This commit is contained in:
Andy Shevchenko
2018-08-01 15:47:14 -07:00
committed by Dmitry Torokhov
parent 5d81a787bd
commit 4e2ec39ddb
1 changed files with 4 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
drivers/input/keyboard/gpio_keys.c
View File

@@ -196,7 +196,7 @@ static ssize_t gpio_keys_attr_show_helper(struct gpio_keys_drvdata *ddata,
ssize_t ret; ssize_t ret;
int i; int i;
bits = kcalloc(BITS_TO_LONGS(n_events), sizeof(*bits), GFP_KERNEL); bits = bitmap_zalloc(n_events, GFP_KERNEL);
if (!bits) if (!bits)
return -ENOMEM; return -ENOMEM;
@@ -216,7 +216,7 @@ static ssize_t gpio_keys_attr_show_helper(struct gpio_keys_drvdata *ddata,
buf[ret++] = '\n'; buf[ret++] = '\n';
buf[ret] = '\0'; buf[ret] = '\0';
kfree(bits); bitmap_free(bits);
return ret; return ret;
} }
@@ -240,7 +240,7 @@ static ssize_t gpio_keys_attr_store_helper(struct gpio_keys_drvdata *ddata,
ssize_t error; ssize_t error;
int i; int i;
bits = kcalloc(BITS_TO_LONGS(n_events), sizeof(*bits), GFP_KERNEL); bits = bitmap_zalloc(n_events, GFP_KERNEL);
if (!bits) if (!bits)
return -ENOMEM; return -ENOMEM;
@@ -284,7 +284,7 @@ static ssize_t gpio_keys_attr_store_helper(struct gpio_keys_drvdata *ddata,
mutex_unlock(&ddata->disable_lock); mutex_unlock(&ddata->disable_lock);
out: out:
kfree(bits); bitmap_free(bits);
return error; return error;
} }