leandrof/linux
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

libbpf: Remove unneeded check for flags during tc detach

Browse Source 
Coverity complained about this being unreachable code. It is right
because we already enforce flags to be unset, so a check validating
the flag value is redundant.

Fixes: 715c5ce454 ("libbpf: Add low level TC-BPF management API")
Signed-off-by: Kumar Kartikeya Dwivedi <memxor@gmail.com>
Signed-off-by: Daniel Borkmann <daniel@iogearbox.net>
Link: https://lore.kernel.org/bpf/20210612023502.1283837-2-memxor@gmail.com
This commit is contained in:
Kumar Kartikeya Dwivedi
2021-06-12 08:05:00 +05:30
committed by Daniel Borkmann
parent ca16b429f3
commit 4e164f8716
1 changed files with 0 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
tools/lib/bpf/netlink.c
View File

@@ -675,8 +675,6 @@ static int __bpf_tc_detach(const struct bpf_tc_hook *hook,
return -EINVAL; return -EINVAL;
if (priority > UINT16_MAX) if (priority > UINT16_MAX)
return -EINVAL; return -EINVAL;
if (flags & ~BPF_TC_F_REPLACE)
return -EINVAL;
if (!flush) { if (!flush) {
if (!handle || !priority) if (!handle || !priority)
return -EINVAL; return -EINVAL;