forked from Minki/linux
dm btree: fix leak of bufio-backed block in btree_split_beneath error path
btree_split_beneath()'s error path had an outstanding FIXME that speaks directly to the potential for _not_ cleaning up a previously allocated bufio-backed block. Fix this by releasing the previously allocated bufio block using unlock_block(). Reported-by: Mikulas Patocka <mpatocka@redhat.com> Signed-off-by: Mike Snitzer <snitzer@redhat.com> Acked-by: Joe Thornber <thornber@redhat.com> Cc: stable@vger.kernel.org
This commit is contained in:
parent
2871c69e02
commit
4dcb8b57df
@ -523,7 +523,7 @@ static int btree_split_beneath(struct shadow_spine *s, uint64_t key)
|
|||||||
|
|
||||||
r = new_block(s->info, &right);
|
r = new_block(s->info, &right);
|
||||||
if (r < 0) {
|
if (r < 0) {
|
||||||
/* FIXME: put left */
|
unlock_block(s->info, left);
|
||||||
return r;
|
return r;
|
||||||
}
|
}
|
||||||
|
|
||||||
|
Loading…
Reference in New Issue
Block a user