leandrof/linux
1
0
Fork 0
forked from Minki/linux
Code Issues Pull Requests Packages Projects Releases Wiki Activity

perf/hw_breakpoint: test: Skip the test if dependencies unmet

Browse Source 
Running the test currently fails on non-SMP systems, despite being
enabled by default. This means that running the test with:

 ./tools/testing/kunit/kunit.py run --arch x86_64 hw_breakpoint

results in every hw_breakpoint test failing with:

 # test_one_cpu: failed to initialize: -22
 not ok 1 - test_one_cpu

Instead, use kunit_skip(), which will mark the test as skipped, and give
a more comprehensible message:

 ok 1 - test_one_cpu # SKIP not enough cpus

This makes it more obvious that the test is not suited to the test
environment, and so wasn't run, rather than having run and failed.

Signed-off-by: David Gow <davidgow@google.com>
Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Reviewed-by: Daniel Latypov <dlatypov@google.com>
Acked-by: Marco Elver <elver@google.com>
Link: https://lore.kernel.org/r/20221026141040.1609203-1-davidgow@google.com
This commit is contained in:
David Gow 2022-10-26 22:10:40 +08:00 committed by Peter Zijlstra
parent 30a0b95b13
commit 4b18cb3f74
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
kernel/events/hw_breakpoint_test.c
View File

@ -295,11 +295,11 @@ static int test_init(struct kunit *test)
{ {
/* Most test cases want 2 distinct CPUs. */ /* Most test cases want 2 distinct CPUs. */
if (num_online_cpus() < 2) if (num_online_cpus() < 2)
return -EINVAL; kunit_skip(test, "not enough cpus");
/* Want the system to not use breakpoints elsewhere. */ /* Want the system to not use breakpoints elsewhere. */
if (hw_breakpoint_is_used()) if (hw_breakpoint_is_used())
return -EBUSY; kunit_skip(test, "hw breakpoint already in use");
return 0; return 0;
} }