leandrof/linux
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

driver core: auxiliary bus: Fix memory leak when driver_register() fail

Browse Source 
If driver_register() returns with error we need to free the memory
allocated for auxdrv->driver.name before returning from
__auxiliary_driver_register()

Fixes: 7de3697e9c ("Add auxiliary bus support")
Reviewed-by: Dan Williams <dan.j.williams@intel.com>
Cc: stable <stable@vger.kernel.org>
Signed-off-by: Peter Ujfalusi <peter.ujfalusi@linux.intel.com>
Link: https://lore.kernel.org/r/20210713093438.3173-1-peter.ujfalusi@linux.intel.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
Peter Ujfalusi
2021-07-13 12:34:38 +03:00
committed by Greg Kroah-Hartman
parent 2734d6c1b1
commit 4afa0c22ee
1 changed files with 7 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
drivers/base/auxiliary.c
View File

@@ -231,6 +231,8 @@ EXPORT_SYMBOL_GPL(auxiliary_find_device);
int __auxiliary_driver_register(struct auxiliary_driver *auxdrv, int __auxiliary_driver_register(struct auxiliary_driver *auxdrv,
struct module *owner, const char *modname) struct module *owner, const char *modname)
{ {
int ret;
if (WARN_ON(!auxdrv->probe) || WARN_ON(!auxdrv->id_table)) if (WARN_ON(!auxdrv->probe) || WARN_ON(!auxdrv->id_table))
return -EINVAL; return -EINVAL;
@@ -246,7 +248,11 @@ int __auxiliary_driver_register(struct auxiliary_driver *auxdrv,
auxdrv->driver.bus = &auxiliary_bus_type; auxdrv->driver.bus = &auxiliary_bus_type;
auxdrv->driver.mod_name = modname; auxdrv->driver.mod_name = modname;
return driver_register(&auxdrv->driver); ret = driver_register(&auxdrv->driver);
if (ret)
kfree(auxdrv->driver.name);
return ret;
} }
EXPORT_SYMBOL_GPL(__auxiliary_driver_register); EXPORT_SYMBOL_GPL(__auxiliary_driver_register);