From 4a6806cfcbca2cd7bae94b2d4244dab3aaa1b333 Mon Sep 17 00:00:00 2001 From: Yang Yingliang Date: Tue, 22 Mar 2022 17:02:36 +0800 Subject: [PATCH] net: marvell: prestera: add missing destroy_workqueue() in prestera_module_init() Add the missing destroy_workqueue() before return from prestera_module_init() in the error handling case. Fixes: 4394fbcb78cf ("net: marvell: prestera: handle fib notifications") Signed-off-by: Yang Yingliang Link: https://lore.kernel.org/r/20220322090236.1439649-1-yangyingliang@huawei.com Signed-off-by: Jakub Kicinski --- drivers/net/ethernet/marvell/prestera/prestera_main.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/net/ethernet/marvell/prestera/prestera_main.c b/drivers/net/ethernet/marvell/prestera/prestera_main.c index 1402c7889e78..3952fdcc9240 100644 --- a/drivers/net/ethernet/marvell/prestera/prestera_main.c +++ b/drivers/net/ethernet/marvell/prestera/prestera_main.c @@ -1032,8 +1032,10 @@ static int __init prestera_module_init(void) return -ENOMEM; prestera_owq = alloc_ordered_workqueue("prestera_ordered", 0); - if (!prestera_owq) + if (!prestera_owq) { + destroy_workqueue(prestera_wq); return -ENOMEM; + } return 0; }