leandrof/linux
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

PCI: mvebu: Use gpio_set_value_cansleep()

Browse Source 
We are in a context where we can sleep, and the PCIe reset gpio may be on
an I2C expander.  Use the cansleep() variant when setting the GPIO value.

Tested-by: Willy Tarreau <w@1wt.eu> (Iomega iConnect Kirkwood, MiraBox Armada 370)
Tested-by: Andrew Lunn <andrew@lunn.ch> (D-Link DIR664 Kirkwood)
Tested-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com> (Armada XP GP)
Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk>
Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
Reviewed-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
This commit is contained in:
Russell King 2015-10-03 19:13:12 +01:00 committed by Bjorn Helgaas
parent 3884d846a4
commit 4a2eae2359
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
drivers/pci/host/pci-mvebu.c
View File

@ -1111,8 +1111,8 @@ static int mvebu_pcie_probe(struct platform_device *pdev)
of_property_read_u32(child, "reset-delay-us",
&reset_udelay);
gpio_set_value(port->reset_gpio,
(port->reset_active_low) ? 1 : 0);
gpio_set_value_cansleep(port->reset_gpio,
!!port->reset_active_low);
msleep(reset_udelay/1000);
}