leandrof/linux
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Staging: lustre: Use memdup_user rather than duplicating its implementation

Browse Source 
This patch uses memdup_user rather than duplicating its implementation

Signed-off-by: Abdul Hussain <habdul@visteon.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
Abdul Hussain 2015-06-16 07:05:17 +00:00 committed by Greg Kroah-Hartman
parent 0c027bc378
commit 4a07594e70
1 changed files with 9 additions and 23 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

32
drivers/staging/lustre/lustre/llite/dir.c
View File

@ -1747,15 +1747,9 @@ out_quotactl:
struct hsm_user_request *hur;
ssize_t totalsize;
hur = kzalloc(sizeof(*hur), GFP_NOFS);
if (!hur)
return -ENOMEM;
/* We don't know the true size yet; copy the fixed-size part */
if (copy_from_user(hur, (void *)arg, sizeof(*hur))) {
kfree(hur);
return -EFAULT;
}
hur = memdup_user((void *)arg, sizeof(*hur));
if (IS_ERR(hur))
return PTR_ERR(hur);
/* Compute the whole struct size */
totalsize = hur_len(hur);
@ -1833,13 +1827,9 @@ out_quotactl:
struct hsm_copy *copy;
int rc;
copy = kzalloc(sizeof(*copy), GFP_NOFS);
if (!copy)
return -ENOMEM;
if (copy_from_user(copy, (char *)arg, sizeof(*copy))) {
kfree(copy);
return -EFAULT;
}
copy = memdup_user((char *)arg, sizeof(*copy));
if (IS_ERR(copy))
return PTR_ERR(copy);
rc = ll_ioc_copy_start(inode->i_sb, copy);
if (copy_to_user((char *)arg, copy, sizeof(*copy)))
@ -1852,13 +1842,9 @@ out_quotactl:
struct hsm_copy *copy;
int rc;
copy = kzalloc(sizeof(*copy), GFP_NOFS);
if (!copy)
return -ENOMEM;
if (copy_from_user(copy, (char *)arg, sizeof(*copy))) {
kfree(copy);
return -EFAULT;
}
copy = memdup_user((char *)arg, sizeof(*copy));
if (IS_ERR(copy))
return PTR_ERR(copy);
rc = ll_ioc_copy_end(inode->i_sb, copy);
if (copy_to_user((char *)arg, copy, sizeof(*copy)))