leandrof/linux
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

leds: lm3692x: Simplify with dev_err_probe()

Browse Source 
Common pattern of handling deferred probe can be simplified with
dev_err_probe().  Less code and also it prints the error value.

Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
Signed-off-by: Pavel Machek <pavel@ucw.cz>
This commit is contained in:
Krzysztof Kozlowski 2020-08-26 16:50:10 +02:00 committed by Pavel Machek
parent 23bdfe0042
commit 47eaa8ba12
1 changed files with 4 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
drivers/leds/leds-lm3692x.c
View File

@ -394,13 +394,10 @@ static int lm3692x_probe_dt(struct lm3692x_led *led)
led->regulator = devm_regulator_get_optional(&led->client->dev, "vled"); led->regulator = devm_regulator_get_optional(&led->client->dev, "vled");
if (IS_ERR(led->regulator)) { if (IS_ERR(led->regulator)) {
ret = PTR_ERR(led->regulator); ret = PTR_ERR(led->regulator);
if (ret != -ENODEV) { if (ret != -ENODEV)
if (ret != -EPROBE_DEFER) return dev_err_probe(&led->client->dev, ret,
dev_err(&led->client->dev, "Failed to get vled regulator\n");
"Failed to get vled regulator: %d\n",
ret);
return ret;
}
led->regulator = NULL; led->regulator = NULL;
} }