leandrof/linux
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

tcp: Fix a data-race around sysctl_tcp_max_orphans.

Browse Source 
While reading sysctl_tcp_max_orphans, it can be changed concurrently.
So, we need to add READ_ONCE() to avoid a data-race.

Fixes: 1da177e4c3 ("Linux-2.6.12-rc2")
Signed-off-by: Kuniyuki Iwashima <kuniyu@amazon.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
Kuniyuki Iwashima 2022-07-06 16:39:58 -07:00 committed by David S. Miller
parent e877820877
commit 47e6ab24e8
1 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
net/ipv4/tcp.c
View File

@ -2715,7 +2715,8 @@ static void tcp_orphan_update(struct timer_list *unused)
static bool tcp_too_many_orphans(int shift) static bool tcp_too_many_orphans(int shift)
{ {
return READ_ONCE(tcp_orphan_cache) << shift > sysctl_tcp_max_orphans; return READ_ONCE(tcp_orphan_cache) << shift >
READ_ONCE(sysctl_tcp_max_orphans);
} }
bool tcp_check_oom(struct sock *sk, int shift) bool tcp_check_oom(struct sock *sk, int shift)