leandrof/linux
1
0
Fork 0
forked from Minki/linux
Code Issues Pull Requests Packages Projects Releases Wiki Activity

net: dsa: Pass ndo_setup_tc slave callback to drivers

Browse Source 
DSA currently handles shared block filters (for the classifier-action
qdisc) in the core due to what I believe are simply pragmatic reasons -
hiding the complexity from drivers and offerring a simple API for port
mirroring.

Extend the dsa_slave_setup_tc function by passing all other qdisc
offloads to the driver layer, where the driver may choose what it
implements and how. DSA is simply a pass-through in this case.

Signed-off-by: Vladimir Oltean <olteanv@gmail.com>
Acked-by: Kurt Kanzenbach <kurt@linutronix.de>
Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
Acked-by: Ilias Apalodimas <ilias.apalodimas@linaro.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
Vladimir Oltean 2019-09-15 04:59:59 +03:00 committed by David S. Miller
parent 9c66d15646
commit 47d23af292
2 changed files with 10 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
include/net/dsa.h
View File

@ -515,6 +515,8 @@ struct dsa_switch_ops {
bool ingress); bool ingress);
void (*port_mirror_del)(struct dsa_switch *ds, int port, void (*port_mirror_del)(struct dsa_switch *ds, int port,
struct dsa_mall_mirror_tc_entry *mirror); struct dsa_mall_mirror_tc_entry *mirror);
int (*port_setup_tc)(struct dsa_switch *ds, int port,
enum tc_setup_type type, void *type_data);
/* /*
* Cross-chip operations * Cross-chip operations

12
net/dsa/slave.c
View File

@ -1035,12 +1035,16 @@ static int dsa_slave_setup_tc_block(struct net_device *dev,
static int dsa_slave_setup_tc(struct net_device *dev, enum tc_setup_type type, static int dsa_slave_setup_tc(struct net_device *dev, enum tc_setup_type type,
void *type_data) void *type_data)
{ {
switch (type) { struct dsa_port *dp = dsa_slave_to_port(dev);
case TC_SETUP_BLOCK: struct dsa_switch *ds = dp->ds;
if (type == TC_SETUP_BLOCK)
return dsa_slave_setup_tc_block(dev, type_data); return dsa_slave_setup_tc_block(dev, type_data);
default:
if (!ds->ops->port_setup_tc)
return -EOPNOTSUPP; return -EOPNOTSUPP;
}
return ds->ops->port_setup_tc(ds, dp->index, type, type_data);
} }
static void dsa_slave_get_stats64(struct net_device *dev, static void dsa_slave_get_stats64(struct net_device *dev,