leandrof/linux
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Revert "r8169: use netif_receive_skb_list batching"

Browse Source 
This reverts commit 6578229d4e.
netif_receive_skb_list() doesn't support GRO, therefore we may have
scenarios with decreased performance. See discussion here [0].

[0] https://marc.info/?t=155403847400001&r=1&w=2

Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
Heiner Kallweit 2019-04-03 19:54:12 +02:00 committed by David S. Miller
parent f6fee16dbb
commit 448a24130b
1 changed files with 1 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
drivers/net/ethernet/realtek/r8169.c
View File

@ -6426,7 +6426,6 @@ static int rtl_rx(struct net_device *dev, struct rtl8169_private *tp, u32 budget
{
unsigned int cur_rx, rx_left;
unsigned int count;
LIST_HEAD(rx_list);
cur_rx = tp->cur_rx;
@ -6502,7 +6501,7 @@ process_pkt:
if (skb->pkt_type == PACKET_MULTICAST)
dev->stats.multicast++;
list_add_tail(&skb->list, &rx_list);
napi_gro_receive(&tp->napi, skb);
u64_stats_update_begin(&tp->rx_stats.syncp);
tp->rx_stats.packets++;
@ -6517,8 +6516,6 @@ release_descriptor:
count = cur_rx - tp->cur_rx;
tp->cur_rx = cur_rx;
netif_receive_skb_list(&rx_list);
return count;
}