leandrof/linux
1
0
Fork 0
forked from Minki/linux
Code Issues Pull Requests Packages Projects Releases Wiki Activity

perf hists browser: Fix up some branch alignment

Browse Source 
Those asprintf return checks should be aligned with the other
conditionals, fix it.

Also add {} blocks to further clarify.

Cc: Adrian Hunter <adrian.hunter@intel.com>
Cc: Borislav Petkov <bp@suse.de>
Cc: David Ahern <dsahern@gmail.com>
Cc: Don Zickus <dzickus@redhat.com>
Cc: Frederic Weisbecker <fweisbec@gmail.com>
Cc: Jiri Olsa <jolsa@redhat.com>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Stephane Eranian <eranian@google.com>
echo Link: http://lkml.kernel.org/n/tip-`ranpwd -l 24`@git.kernel.org
Link: http://lkml.kernel.org/n/tip-nqgs07jfphbkw67wja870d3r@git.kernel.org
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
This commit is contained in:
Arnaldo Carvalho de Melo 2015-03-16 17:46:57 -03:00
parent 0ba332f70a
commit 446fb96c4a
1 changed files with 6 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
tools/perf/ui/browsers/hists.c
View File

@ -1623,17 +1623,17 @@ static int perf_evsel__hists_browse(struct perf_evsel *evsel, int nr_events,
if (bi->from.sym != NULL && if (bi->from.sym != NULL &&
!bi->from.map->dso->annotate_warned && !bi->from.map->dso->annotate_warned &&
asprintf(&options[nr_options], "Annotate %s", asprintf(&options[nr_options], "Annotate %s", bi->from.sym->name) > 0) {
bi->from.sym->name) > 0)
annotate_f = nr_options++; annotate_f = nr_options++;
}
if (bi->to.sym != NULL && if (bi->to.sym != NULL &&
!bi->to.map->dso->annotate_warned && !bi->to.map->dso->annotate_warned &&
(bi->to.sym != bi->from.sym || (bi->to.sym != bi->from.sym ||
bi->to.map->dso != bi->from.map->dso) && bi->to.map->dso != bi->from.map->dso) &&
asprintf(&options[nr_options], "Annotate %s", asprintf(&options[nr_options], "Annotate %s", bi->to.sym->name) > 0) {
bi->to.sym->name) > 0)
annotate_t = nr_options++; annotate_t = nr_options++;
}
} else { } else {
if (browser->selection->sym != NULL && if (browser->selection->sym != NULL &&
!browser->selection->map->dso->annotate_warned) { !browser->selection->map->dso->annotate_warned) {
@ -1643,8 +1643,9 @@ static int perf_evsel__hists_browse(struct perf_evsel *evsel, int nr_events,
if (notes->src && if (notes->src &&
asprintf(&options[nr_options], "Annotate %s", asprintf(&options[nr_options], "Annotate %s",
browser->selection->sym->name) > 0) browser->selection->sym->name) > 0) {
annotate = nr_options++; annotate = nr_options++;
}
} }
} }
skip_annotation: skip_annotation: