leandrof/linux
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

[PATCH] Fix IPMI watchdog set_param_str() using kstrdup

Browse Source 
set_param_str() cannot use kstrdup() to duplicate the parameter.  That's
fine when the driver is compiled as a module but it sure is not when built
into the kernel as the kernel parameters are parsed before the kmalloc
slabs are setup.

Signed-off-by: Sebastien Dugué <sebastien.dugue@bull.net>
Acked-by: Corey Minyard <minyard@acm.org>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
This commit is contained in:
Sebastien Dugué 2006-12-29 16:46:53 -08:00 committed by Linus Torvalds
parent 7479b1ce5e
commit 43cdff92ad
1 changed files with 5 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
drivers/char/ipmi/ipmi_watchdog.c
View File

@ -216,13 +216,13 @@ static int set_param_str(const char *val, struct kernel_param *kp)
{ {
action_fn fn = (action_fn) kp->arg; action_fn fn = (action_fn) kp->arg;
int rv = 0; int rv = 0;
char *dup, *s; char valcp[16];
char *s;
dup = kstrdup(val, GFP_KERNEL); strncpy(valcp, val, 16);
if (!dup) valcp[15] = '\0';
return -ENOMEM;
s = strstrip(dup); s = strstrip(valcp);
down_read(&register_sem); down_read(&register_sem);
rv = fn(s, NULL); rv = fn(s, NULL);
@ -235,7 +235,6 @@ static int set_param_str(const char *val, struct kernel_param *kp)
out_unlock: out_unlock:
up_read(&register_sem); up_read(&register_sem);
kfree(dup);
return rv; return rv;
} }