leandrof/linux
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

ARM: dts: exynos: override GPIO keys node by label in Exynos4412 Odroid family

Browse Source 
Using full paths to extend or override a device tree node is error
prone.  If there was a typo error, a new node will be created instead of
extending the existing node.  This will lead to run-time errors that
could be hard to detect.

A mistyped label on the other hand, will cause a dtc compile error
(during build time).

Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
Link: https://lore.kernel.org/r/20201027170947.132725-4-krzk@kernel.org
This commit is contained in:
Krzysztof Kozlowski 2020-10-27 18:09:38 +01:00
parent d918633c8a
commit 43552e6d5a
2 changed files with 13 additions and 13 deletions

2
arch/arm/boot/dts/exynos4412-odroid-common.dtsi
View File

@ -22,7 +22,7 @@
reg = <0x0204F000 0x1000>;
};
gpio_keys {
gpio_keys: gpio-keys {
compatible = "gpio-keys";
pinctrl-names = "default";
pinctrl-0 = <&gpio_power_key>;

24
arch/arm/boot/dts/exynos4412-odroidx.dts
View File

@ -36,18 +36,6 @@
};
};
gpio_keys {
pinctrl-0 = <&gpio_power_key &gpio_home_key>;
home_key {
gpios = <&gpx2 2 GPIO_ACTIVE_HIGH>;
linux,code = <KEY_HOME>;
label = "home key";
debounce-interval = <10>;
wakeup-source;
};
};
regulator_p3v3 {
compatible = "regulator-fixed";
regulator-name = "p3v3_en";
@ -76,6 +64,18 @@
phy-names = "hsic0";
};
&gpio_keys {
pinctrl-0 = <&gpio_power_key &gpio_home_key>;
home-key {
gpios = <&gpx2 2 GPIO_ACTIVE_HIGH>;
linux,code = <KEY_HOME>;
label = "home key";
debounce-interval = <10>;
wakeup-source;
};
};
&mshc_0 {
vqmmc-supply = <&buck8_reg>;
};