leandrof/linux
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

staging: wfx: improve error message on unexpected confirmation

Browse Source 
When driver receives an unexpected answer from the device, it shows
"unsupported HIF ID". That message does not represent the real error.

Signed-off-by: Jérôme Pouiller <jerome.pouiller@silabs.com>
Link: https://lore.kernel.org/r/20191217161318.31402-15-Jerome.Pouiller@silabs.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
Jérôme Pouiller 2019-12-17 16:14:46 +00:00 committed by Greg Kroah-Hartman
parent 88d54d6e15
commit 42edb537a3
1 changed files with 6 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
drivers/staging/wfx/hif_rx.c
View File

@ -358,7 +358,12 @@ void wfx_handle_rx(struct wfx_dev *wdev, struct sk_buff *skb)
goto free;
}
}
dev_err(wdev->dev, "unsupported HIF ID %02x\n", hif_id);
if (hif_id & 0x80)
dev_err(wdev->dev, "unsupported HIF indication: ID %02x\n",
hif_id);
else
dev_err(wdev->dev, "unexpected HIF confirmation: ID %02x\n",
hif_id);
free:
dev_kfree_skb(skb);
}