leandrof/linux
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

staging: comedi: addi_apci_1516: cleanup the s->subdev_flags

Browse Source 
The flags SDF_GROUND and SDF_COMMON only have meaning for analog
input/output subdevices. Remove these flags from the digital
input/output and timer subdevices in this driver.

The digital output subdevice does not need the SDF_READABLE flags.
Remove it.

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Cc: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
H Hartley Sweeten 2012-11-13 13:45:39 -07:00 committed by Greg Kroah-Hartman
parent 5aaa8bc35b
commit 42e07ce63e
1 changed files with 3 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
drivers/staging/comedi/drivers/addi_apci_1516.c
View File

@ -238,7 +238,7 @@ static int __devinit apci1516_auto_attach(struct comedi_device *dev,
s = &dev->subdevices[0];
if (this_board->di_nchan) {
s->type = COMEDI_SUBD_DI;
s->subdev_flags = SDF_READABLE | SDF_GROUND | SDF_COMMON;
s->subdev_flags = SDF_READABLE;
s->n_chan = this_board->di_nchan;
s->maxdata = 1;
s->range_table = &range_digital;
@ -250,8 +250,7 @@ static int __devinit apci1516_auto_attach(struct comedi_device *dev,
s = &dev->subdevices[1];
if (this_board->do_nchan) {
s->type = COMEDI_SUBD_DO;
s->subdev_flags =
SDF_READABLE | SDF_WRITEABLE | SDF_GROUND | SDF_COMMON;
s->subdev_flags = SDF_WRITEABLE;
s->n_chan = this_board->do_nchan;
s->maxdata = 1;
s->range_table = &range_digital;
@ -264,7 +263,7 @@ static int __devinit apci1516_auto_attach(struct comedi_device *dev,
s = &dev->subdevices[2];
if (this_board->has_timer) {
s->type = COMEDI_SUBD_TIMER;
s->subdev_flags = SDF_WRITEABLE | SDF_GROUND | SDF_COMMON;
s->subdev_flags = SDF_WRITEABLE;
s->n_chan = 1;
s->maxdata = 0;
s->range_table = &range_digital;