leandrof/linux
1
0
Fork 0
forked from Minki/linux
Code Issues Pull Requests Packages Projects Releases Wiki Activity

stmmac: remove custom implementation of print_hex_dump()

Browse Source 
There is a kernel helper to dump buffers in a hexdecimal format. This patch
substitutes the open coded function by calling that helper.

The output is slightly changed:
 - no lead space
 - ASCII part will be printed along with the dump
 - offset is longer than 3 characters (now 8)

Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
Andy Shevchenko 2014-11-07 16:53:12 +02:00 committed by David S. Miller
parent 7f6d46704f
commit 424c4f7875
1 changed files with 2 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
View File

@ -191,14 +191,8 @@ static void stmmac_clk_csr_set(struct stmmac_priv *priv)
static void print_pkt(unsigned char *buf, int len) static void print_pkt(unsigned char *buf, int len)
{ {
int j; pr_debug("len = %d byte, buf addr: 0x%p\n", len, buf);
pr_debug("len = %d byte, buf addr: 0x%p", len, buf); print_hex_dump_bytes("", DUMP_PREFIX_OFFSET, buf, len);
for (j = 0; j < len; j++) {
if ((j % 16) == 0)
pr_debug("\n %03x:", j);
pr_debug(" %02x", buf[j]);
}
pr_debug("\n");
} }
/* minimum number of free TX descriptors required to wake up TX process */ /* minimum number of free TX descriptors required to wake up TX process */