leandrof/linux
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

net: pch_gbe: remove unneeded MODULE_VERSION() call

Browse Source 
Remove MODULE_VERSION(), as it doesn't seem to serve any practical purpose.
For in-tree drivers, the kernel version matters. The code received lots of
changes, but module version remained constant, since the driver landed in
mainline. So, this version doesn't seem have any practical meaning anymore.

Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Tested-by: Flavio Suligoi <f.suligoi@asem.it>
Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
Andy Shevchenko 2021-05-10 19:39:31 +03:00 committed by David S. Miller
parent 443ef39b49
commit 40b161bb16
3 changed files with 2 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
drivers/net/ethernet/oki-semi/pch_gbe/pch_gbe.h
View File

@ -596,8 +596,6 @@ struct pch_gbe_adapter {
#define pch_gbe_hw_to_adapter(hw) container_of(hw, struct pch_gbe_adapter, hw) #define pch_gbe_hw_to_adapter(hw) container_of(hw, struct pch_gbe_adapter, hw)
extern const char pch_driver_version[];
/* pch_gbe_main.c */ /* pch_gbe_main.c */
int pch_gbe_up(struct pch_gbe_adapter *adapter); int pch_gbe_up(struct pch_gbe_adapter *adapter);
void pch_gbe_down(struct pch_gbe_adapter *adapter); void pch_gbe_down(struct pch_gbe_adapter *adapter);

2
drivers/net/ethernet/oki-semi/pch_gbe/pch_gbe_ethtool.c
View File

@ -8,6 +8,8 @@
#include "pch_gbe.h" #include "pch_gbe.h"
#include "pch_gbe_phy.h" #include "pch_gbe_phy.h"
static const char pch_driver_version[] = "1.01";
/* /*
* pch_gbe_stats - Stats item information * pch_gbe_stats - Stats item information
*/ */

4
drivers/net/ethernet/oki-semi/pch_gbe/pch_gbe_main.c
View File

@ -18,9 +18,6 @@
#include <linux/ptp_pch.h> #include <linux/ptp_pch.h>
#include <linux/gpio.h> #include <linux/gpio.h>
#define DRV_VERSION "1.01"
const char pch_driver_version[] = DRV_VERSION;
#define PCH_GBE_MAR_ENTRIES 16 #define PCH_GBE_MAR_ENTRIES 16
#define PCH_GBE_SHORT_PKT 64 #define PCH_GBE_SHORT_PKT 64
#define DSC_INIT16 0xC000 #define DSC_INIT16 0xC000
@ -2728,7 +2725,6 @@ module_pci_driver(pch_gbe_driver);
MODULE_DESCRIPTION("EG20T PCH Gigabit ethernet Driver"); MODULE_DESCRIPTION("EG20T PCH Gigabit ethernet Driver");
MODULE_AUTHOR("LAPIS SEMICONDUCTOR, <tshimizu818@gmail.com>"); MODULE_AUTHOR("LAPIS SEMICONDUCTOR, <tshimizu818@gmail.com>");
MODULE_LICENSE("GPL"); MODULE_LICENSE("GPL");
MODULE_VERSION(DRV_VERSION);
MODULE_DEVICE_TABLE(pci, pch_gbe_pcidev_id); MODULE_DEVICE_TABLE(pci, pch_gbe_pcidev_id);
/* pch_gbe_main.c */ /* pch_gbe_main.c */