leandrof/linux
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

net: stmmac: dwmac_lib: remove unnecessary checks in dwmac_dma_reset()

Browse Source 
it will check the return value of dwmac_dma_reset() in the
stmmac_init_dma_engine() function and report an error if the
return value is not zero. so don't need check here.

Signed-off-by: Dejin Zheng <zhengdejin5@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
Dejin Zheng 2020-03-19 21:16:38 +08:00 committed by David S. Miller
parent 09d65e6d63
commit 3fd177cb2b
1 changed files with 1 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
drivers/net/ethernet/stmicro/stmmac/dwmac_lib.c
View File

@ -16,19 +16,14 @@
int dwmac_dma_reset(void __iomem *ioaddr) int dwmac_dma_reset(void __iomem *ioaddr)
{ {
u32 value = readl(ioaddr + DMA_BUS_MODE); u32 value = readl(ioaddr + DMA_BUS_MODE);
int err;
/* DMA SW reset */ /* DMA SW reset */
value |= DMA_BUS_MODE_SFT_RESET; value |= DMA_BUS_MODE_SFT_RESET;
writel(value, ioaddr + DMA_BUS_MODE); writel(value, ioaddr + DMA_BUS_MODE);
err = readl_poll_timeout(ioaddr + DMA_BUS_MODE, value, return readl_poll_timeout(ioaddr + DMA_BUS_MODE, value,
!(value & DMA_BUS_MODE_SFT_RESET), !(value & DMA_BUS_MODE_SFT_RESET),
10000, 100000); 10000, 100000);
if (err)
return -EBUSY;
return 0;
} }
/* CSR1 enables the transmit DMA to check for new descriptor */ /* CSR1 enables the transmit DMA to check for new descriptor */