leandrof/linux
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

irqchip/loongson-htpic: Fix build warnings

Browse Source 
Fix build warnings as below:

   drivers/irqchip/irq-loongson-htpic.c: In function 'htpic_reg_init':
>> drivers/irqchip/irq-loongson-htpic.c:62:12: warning: variable 'val' set but not used [-Wunused-but-set-variable]
      62 |   uint32_t val;
         |            ^~~
   drivers/irqchip/irq-loongson-htpic.c: At top level:
>> drivers/irqchip/irq-loongson-htpic.c:84:12: warning: no previous prototype for 'htpic_of_init' [-Wmissing-prototypes]
      84 | int __init htpic_of_init(struct device_node *node, struct device_node *parent)
         |            ^~~~~~~~~~~~~

Fixes: a93f1d903f ("irqchip: Add driver for Loongson-3 HyperTransport PIC controller")
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: Huacai Chen <chenhuacai@kernel.org>
Signed-off-by: Marc Zyngier <maz@kernel.org>
Link: https://lore.kernel.org/r/1607159744-995-1-git-send-email-chenhuacai@kernel.org
This commit is contained in:
Huacai Chen 2020-12-05 17:15:44 +08:00 committed by Marc Zyngier
parent 42a590b0fd
commit 3ee36352e2
1 changed files with 3 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
drivers/irqchip/irq-loongson-htpic.c
View File

@ -59,11 +59,10 @@ static void htpic_reg_init(void)
int i; int i;
for (i = 0; i < HTINT_NUM_VECTORS; i++) { for (i = 0; i < HTINT_NUM_VECTORS; i++) {
uint32_t val;
/* Disable all HT Vectors */ /* Disable all HT Vectors */
writel(0x0, htpic->base + HTINT_EN_OFF + i * 0x4); writel(0x0, htpic->base + HTINT_EN_OFF + i * 0x4);
val = readl(htpic->base + i * 0x4); /* Read back to force write */
(void) readl(htpic->base + i * 0x4);
/* Ack all possible pending IRQs */ /* Ack all possible pending IRQs */
writel(GENMASK(31, 0), htpic->base + i * 0x4); writel(GENMASK(31, 0), htpic->base + i * 0x4);
} }
@ -81,7 +80,7 @@ struct syscore_ops htpic_syscore_ops = {
.resume = htpic_resume, .resume = htpic_resume,
}; };
int __init htpic_of_init(struct device_node *node, struct device_node *parent) static int __init htpic_of_init(struct device_node *node, struct device_node *parent)
{ {
unsigned int parent_irq[4]; unsigned int parent_irq[4];
int i, err; int i, err;