leandrof/linux
1
0
Fork 0
forked from Minki/linux
Code Issues Pull Requests Packages Projects Releases Wiki Activity

block/badblocks: Remove redundant assignments

Browse Source 
Get rid of redundant assignments to a variable sectors from functions
badblocks_check and badblocks_clear. This variable, that is a function
parameter, is being assigned a value that is never read until the end of
function.

Reported by clang-tidy [deadcode.DeadStores]

Signed-off-by: Michal Orzel <michalorzel.eng@gmail.com>
Link: https://lore.kernel.org/r/20220423113811.13335-1-michalorzel.eng@gmail.com
Signed-off-by: Jens Axboe <axboe@kernel.dk>
This commit is contained in:
Michal Orzel 2022-04-23 13:38:07 +02:00 committed by Jens Axboe
parent 5f0614a55e
commit 3de2e5f28c
1 changed files with 0 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
block/badblocks.c
View File

@ -65,7 +65,6 @@ int badblocks_check(struct badblocks *bb, sector_t s, int sectors,
s >>= bb->shift; s >>= bb->shift;
target += (1<<bb->shift) - 1; target += (1<<bb->shift) - 1;
target >>= bb->shift; target >>= bb->shift;
sectors = target - s;
} }
/* 'target' is now the first block after the bad range */ /* 'target' is now the first block after the bad range */
@ -345,7 +344,6 @@ int badblocks_clear(struct badblocks *bb, sector_t s, int sectors)
s += (1<<bb->shift) - 1; s += (1<<bb->shift) - 1;
s >>= bb->shift; s >>= bb->shift;
target >>= bb->shift; target >>= bb->shift;
sectors = target - s;
} }
write_seqlock_irq(&bb->lock); write_seqlock_irq(&bb->lock);