leandrof/linux
1
0
Fork 0
forked from Minki/linux
Code Issues Pull Requests Packages Projects Releases Wiki Activity

net: ax88796c: Fix clang -Wimplicit-fallthrough in ax88796c_set_mac()

Browse Source 
Clang warns:

drivers/net/ethernet/asix/ax88796c_main.c:696:2: error: unannotated fall-through between switch labels [-Werror,-Wimplicit-fallthrough]
        case SPEED_10:
        ^
drivers/net/ethernet/asix/ax88796c_main.c:696:2: note: insert 'break;' to avoid fall-through
        case SPEED_10:
        ^
        break;
drivers/net/ethernet/asix/ax88796c_main.c:706:2: error: unannotated fall-through between switch labels [-Werror,-Wimplicit-fallthrough]
        case DUPLEX_HALF:
        ^
drivers/net/ethernet/asix/ax88796c_main.c:706:2: note: insert 'break;' to avoid fall-through
        case DUPLEX_HALF:
        ^
        break;

Clang is a little more pedantic than GCC, which permits implicit
fallthroughs to cases that contain just break or return. Clang's version
is more in line with the kernel's own stance in deprecated.rst, which
states that all switch/case blocks must end in either break,
fallthrough, continue, goto, or return. Add the missing breaks to fix
the warning.

Link: https://github.com/ClangBuiltLinux/linux/issues/1491
Signed-off-by: Nathan Chancellor <nathan@kernel.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
Nathan Chancellor 2021-10-25 14:12:38 -07:00 committed by David S. Miller
parent a137c069fb
commit 3c5548812a
1 changed files with 2 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
drivers/net/ethernet/asix/ax88796c_main.c
View File

@ -693,6 +693,7 @@ static void ax88796c_set_mac(struct ax88796c_device *ax_local)
switch (ax_local->speed) { switch (ax_local->speed) {
case SPEED_100: case SPEED_100:
maccr |= MACCR_SPEED_100; maccr |= MACCR_SPEED_100;
break;
case SPEED_10: case SPEED_10:
case SPEED_UNKNOWN: case SPEED_UNKNOWN:
break; break;
@ -703,6 +704,7 @@ static void ax88796c_set_mac(struct ax88796c_device *ax_local)
switch (ax_local->duplex) { switch (ax_local->duplex) {
case DUPLEX_FULL: case DUPLEX_FULL:
maccr |= MACCR_SPEED_100; maccr |= MACCR_SPEED_100;
break;
case DUPLEX_HALF: case DUPLEX_HALF:
case DUPLEX_UNKNOWN: case DUPLEX_UNKNOWN:
break; break;