dev: advertise the new ifindex when the netns iface changes
The goal is to let the user follow an interface that moves to another netns. CC: Jiri Benc <jbenc@redhat.com> CC: Christian Brauner <christian.brauner@ubuntu.com> Signed-off-by: Nicolas Dichtel <nicolas.dichtel@6wind.com> Reviewed-by: Jiri Benc <jbenc@redhat.com> Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
committed by
David S. Miller
parent
c36ac8e230
commit
38e01b3056
@@ -7360,7 +7360,7 @@ static void rollback_registered_many(struct list_head *head)
|
||||
if (!dev->rtnl_link_ops ||
|
||||
dev->rtnl_link_state == RTNL_LINK_INITIALIZED)
|
||||
skb = rtmsg_ifinfo_build_skb(RTM_DELLINK, dev, ~0U, 0,
|
||||
GFP_KERNEL, NULL);
|
||||
GFP_KERNEL, NULL, 0);
|
||||
|
||||
/*
|
||||
* Flush the unicast and multicast chains
|
||||
@@ -8473,7 +8473,7 @@ EXPORT_SYMBOL(unregister_netdev);
|
||||
|
||||
int dev_change_net_namespace(struct net_device *dev, struct net *net, const char *pat)
|
||||
{
|
||||
int err, new_nsid;
|
||||
int err, new_nsid, new_ifindex;
|
||||
|
||||
ASSERT_RTNL();
|
||||
|
||||
@@ -8529,8 +8529,16 @@ int dev_change_net_namespace(struct net_device *dev, struct net *net, const char
|
||||
call_netdevice_notifiers(NETDEV_UNREGISTER, dev);
|
||||
rcu_barrier();
|
||||
call_netdevice_notifiers(NETDEV_UNREGISTER_FINAL, dev);
|
||||
|
||||
new_nsid = peernet2id_alloc(dev_net(dev), net);
|
||||
rtmsg_ifinfo_newnet(RTM_DELLINK, dev, ~0U, GFP_KERNEL, &new_nsid);
|
||||
/* If there is an ifindex conflict assign a new one */
|
||||
if (__dev_get_by_index(net, dev->ifindex))
|
||||
new_ifindex = dev_new_index(net);
|
||||
else
|
||||
new_ifindex = dev->ifindex;
|
||||
|
||||
rtmsg_ifinfo_newnet(RTM_DELLINK, dev, ~0U, GFP_KERNEL, &new_nsid,
|
||||
new_ifindex);
|
||||
|
||||
/*
|
||||
* Flush the unicast and multicast chains
|
||||
@@ -8544,10 +8552,7 @@ int dev_change_net_namespace(struct net_device *dev, struct net *net, const char
|
||||
|
||||
/* Actually switch the network namespace */
|
||||
dev_net_set(dev, net);
|
||||
|
||||
/* If there is an ifindex conflict assign a new one */
|
||||
if (__dev_get_by_index(net, dev->ifindex))
|
||||
dev->ifindex = dev_new_index(net);
|
||||
dev->ifindex = new_ifindex;
|
||||
|
||||
/* Send a netdev-add uevent to the new namespace */
|
||||
kobject_uevent(&dev->dev.kobj, KOBJ_ADD);
|
||||
|
||||
Reference in New Issue
Block a user