forked from Minki/linux
io_uring: check for rollover of buffer ID when providing buffers
We already check if the chosen starting offset for the buffer IDs fit within an unsigned short, as 65535 is the maximum value for a provided buffer. But if the caller asks to add N buffers at offset M, and M + N would exceed the size of the unsigned short, we simply add buffers with wrapping around the ID. This is not necessarily a bug and could in fact be a valid use case, but it seems confusing and inconsistent with the initial check for starting offset. Let's check for wrap consistently, and error the addition if we do need to wrap. Reported-by: Olivier Langlois <olivier@trillion01.com> Link: https://github.com/axboe/liburing/issues/726 Cc: stable@vger.kernel.org Signed-off-by: Jens Axboe <axboe@kernel.dk>
This commit is contained in:
parent
0fc8c2acbf
commit
3851d25c75
@ -346,6 +346,8 @@ int io_provide_buffers_prep(struct io_kiocb *req, const struct io_uring_sqe *sqe
|
|||||||
tmp = READ_ONCE(sqe->off);
|
tmp = READ_ONCE(sqe->off);
|
||||||
if (tmp > USHRT_MAX)
|
if (tmp > USHRT_MAX)
|
||||||
return -E2BIG;
|
return -E2BIG;
|
||||||
|
if (tmp + p->nbufs >= USHRT_MAX)
|
||||||
|
return -EINVAL;
|
||||||
p->bid = tmp;
|
p->bid = tmp;
|
||||||
return 0;
|
return 0;
|
||||||
}
|
}
|
||||||
|
Loading…
Reference in New Issue
Block a user