leandrof/linux
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

include/linux/cpumask.h: fix double string traverse in cpumask_parse

Browse Source 
cpumask_parse() finds first occurrence of either or strchr() and
strlen().  We can do it better with a single call of strchrnul().

[akpm@linux-foundation.org: remove unneeded cast]
Link: http://lkml.kernel.org/r/20190409204208.12190-1-ynorov@marvell.com
Signed-off-by: Yury Norov <ynorov@marvell.com>
Acked-by: Rasmus Villemoes <linux@rasmusvillemoes.dk>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
This commit is contained in:
Yury Norov 2019-05-14 15:44:46 -07:00 committed by Linus Torvalds
parent 4e7301e6df
commit 3713a4e1fd
1 changed files with 1 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
include/linux/cpumask.h
View File

@ -633,8 +633,7 @@ static inline int cpumask_parselist_user(const char __user *buf, int len,
*/ */
static inline int cpumask_parse(const char *buf, struct cpumask *dstp) static inline int cpumask_parse(const char *buf, struct cpumask *dstp)
{ {
char *nl = strchr(buf, '\n'); unsigned int len = strchrnul(buf, '\n') - buf;
unsigned int len = nl ? (unsigned int)(nl - buf) : strlen(buf);
return bitmap_parse(buf, len, cpumask_bits(dstp), nr_cpumask_bits); return bitmap_parse(buf, len, cpumask_bits(dstp), nr_cpumask_bits);
} }