leandrof/linux
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

staging: lustre: obdclass: hoist locking in lu_context_exit()

Browse Source 
Hoist lu_keys_guard locking out of the for loop in lu_context_exit().

Signed-off-by: John L. Hammond <john.hammond@intel.com>
Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-8918
Reviewed-on: https://review.whamcloud.com/24217
Reviewed-by: Dmitry Eremin <dmitry.eremin@intel.com>
Reviewed-by: Jinshan Xiong <jinshan.xiong@gmail.com>
Reviewed-by: Oleg Drokin <oleg.drokin@intel.com>
Signed-off-by: James Simmons <jsimmons@infradead.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
John L. Hammond 2018-05-02 14:21:46 -04:00 committed by Greg Kroah-Hartman
parent a5394d4883
commit 369a6fec39
1 changed files with 7 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
drivers/staging/lustre/lustre/obdclass/lu_object.c
View File

@ -1721,10 +1721,11 @@ void lu_context_exit(struct lu_context *ctx)
LINVRNT(ctx->lc_state == LCS_ENTERED);
ctx->lc_state = LCS_LEFT;
if (ctx->lc_tags & LCT_HAS_EXIT && ctx->lc_value) {
/* could race with key quiescency */
if (ctx->lc_tags & LCT_REMEMBER)
read_lock(&lu_keys_guard);
for (i = 0; i < ARRAY_SIZE(lu_keys); ++i) {
/* could race with key quiescency */
if (ctx->lc_tags & LCT_REMEMBER)
read_lock(&lu_keys_guard);
if (ctx->lc_value[i]) {
struct lu_context_key *key;
@ -1733,9 +1734,10 @@ void lu_context_exit(struct lu_context *ctx)
key->lct_exit(ctx,
key, ctx->lc_value[i]);
}
if (ctx->lc_tags & LCT_REMEMBER)
read_unlock(&lu_keys_guard);
}
if (ctx->lc_tags & LCT_REMEMBER)
read_unlock(&lu_keys_guard);
}
}
EXPORT_SYMBOL(lu_context_exit);