leandrof/linux
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

drm/vboxvideo: Set up fbdev after registering device; remove error checks

Browse Source 
Generic fbdev support is a DRM client. Set it up after registering
the new DRM device. Remove the error checks as the driver's probe
function should not depend on a DRM client's state.

Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
Reviewed-by: Noralf Trønnes <noralf@tronnes.org>
Acked-by: Sam Ravnborg <sam@ravnborg.org>
Acked-by: Gerd Hoffmann <kraxel@redhat.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20200408082641.590-10-tzimmermann@suse.de
This commit is contained in:
Thomas Zimmermann 2020-04-08 10:26:40 +02:00
parent 66459fa21d
commit 3662cd1992
1 changed files with 2 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
drivers/gpu/drm/vboxvideo/vbox_drv.c
View File

@ -78,14 +78,12 @@ static int vbox_pci_probe(struct pci_dev *pdev, const struct pci_device_id *ent)
if (ret) if (ret)
goto err_mode_fini; goto err_mode_fini;
ret = drm_fbdev_generic_setup(&vbox->ddev, 32);
if (ret)
goto err_irq_fini;
ret = drm_dev_register(&vbox->ddev, 0); ret = drm_dev_register(&vbox->ddev, 0);
if (ret) if (ret)
goto err_irq_fini; goto err_irq_fini;
drm_fbdev_generic_setup(&vbox->ddev, 32);
return 0; return 0;
err_irq_fini: err_irq_fini: