leandrof/linux
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

checkpatch: add a multiple blank lines test

Browse Source 
Multiple consecutive blank lines waste screen space.  Emit a --strict
only message with these blank lines.

Signed-off-by: Joe Perches <joe@perches.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
This commit is contained in:
Joe Perches 2014-08-06 16:10:42 -07:00 committed by Linus Torvalds
parent 7f61919144
commit 365dd4eaaf
1 changed files with 11 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
scripts/checkpatch.pl
View File

@ -1642,6 +1642,8 @@ sub process {
my $non_utf8_charset = 0;
my $last_blank_line = 0;
our @report = ();
our $cnt_lines = 0;
our $cnt_error = 0;
@ -2308,6 +2310,15 @@ sub process {
"Please use a blank line after function/struct/union/enum declarations\n" . $hereprev);
}
# check for multiple consecutive blank lines
if ($prevline =~ /^[\+ ]\s*$/ &&
$line =~ /^\+\s*$/ &&
$last_blank_line != ($linenr - 1)) {
CHK("LINE_SPACING",
"Please don't use multiple blank lines\n" . $hereprev);
$last_blank_line = $linenr;
}
# check for missing blank lines after declarations
if ($sline =~ /^\+\s+\S/ && #Not at char 1
# actual declarations