leandrof/linux
1
0
Fork 0
forked from Minki/linux
Code Issues Pull Requests Packages Projects Releases Wiki Activity

drm/sun4i: frontend: Add a quirk structure

Browse Source 
The ACCESS_CTRL bit is not found on all the variants of the frontend, so
let's introduce a structure that will hold whether or not we need to set
it, and associate it with the compatible.

This will be extended for further similar quirks later on.

Reviewed-by: Paul Kocialkowski <paul.kocialkowski@bootlin.com>
Signed-off-by: Maxime Ripard <maxime.ripard@bootlin.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20190118145133.21281-19-paul.kocialkowski@bootlin.com
This commit is contained in:
Maxime Ripard 2019-01-18 15:51:28 +01:00
parent 9401860156
commit 35f366544c
No known key found for this signature in database
GPG Key ID: E3EF0D6F671851C5
2 changed files with 23 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

21
drivers/gpu/drm/sun4i/sun4i_frontend.c
View File

@ -10,6 +10,7 @@
#include <linux/clk.h> #include <linux/clk.h>
#include <linux/component.h> #include <linux/component.h>
#include <linux/module.h> #include <linux/module.h>
#include <linux/of_device.h>
#include <linux/platform_device.h> #include <linux/platform_device.h>
#include <linux/pm_runtime.h> #include <linux/pm_runtime.h>
#include <linux/regmap.h> #include <linux/regmap.h>
@ -75,9 +76,10 @@ static void sun4i_frontend_scaler_init(struct sun4i_frontend *frontend)
{ {
int i; int i;
regmap_write_bits(frontend->regs, SUN4I_FRONTEND_FRM_CTRL_REG, if (frontend->data->has_coef_access_ctrl)
SUN4I_FRONTEND_FRM_CTRL_COEF_ACCESS_CTRL, regmap_write_bits(frontend->regs, SUN4I_FRONTEND_FRM_CTRL_REG,
SUN4I_FRONTEND_FRM_CTRL_COEF_ACCESS_CTRL); SUN4I_FRONTEND_FRM_CTRL_COEF_ACCESS_CTRL,
SUN4I_FRONTEND_FRM_CTRL_COEF_ACCESS_CTRL);
for (i = 0; i < 32; i++) { for (i = 0; i < 32; i++) {
regmap_write(frontend->regs, SUN4I_FRONTEND_CH0_HORZCOEF0_REG(i), regmap_write(frontend->regs, SUN4I_FRONTEND_CH0_HORZCOEF0_REG(i),
@ -553,6 +555,10 @@ static int sun4i_frontend_bind(struct device *dev, struct device *master,
frontend->dev = dev; frontend->dev = dev;
frontend->node = dev->of_node; frontend->node = dev->of_node;
frontend->data = of_device_get_match_data(dev);
if (!frontend->data)
return -ENODEV;
res = platform_get_resource(pdev, IORESOURCE_MEM, 0); res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
regs = devm_ioremap_resource(dev, res); regs = devm_ioremap_resource(dev, res);
if (IS_ERR(regs)) if (IS_ERR(regs))
@ -665,8 +671,15 @@ static const struct dev_pm_ops sun4i_frontend_pm_ops = {
.runtime_suspend = sun4i_frontend_runtime_suspend, .runtime_suspend = sun4i_frontend_runtime_suspend,
}; };
static const struct sun4i_frontend_data sun8i_a33_frontend = {
.has_coef_access_ctrl = true,
};
const struct of_device_id sun4i_frontend_of_table[] = { const struct of_device_id sun4i_frontend_of_table[] = {
{ .compatible = "allwinner,sun8i-a33-display-frontend" }, {
.compatible = "allwinner,sun8i-a33-display-frontend",
.data = &sun8i_a33_frontend
},
{ } { }
}; };
EXPORT_SYMBOL(sun4i_frontend_of_table); EXPORT_SYMBOL(sun4i_frontend_of_table);

6
drivers/gpu/drm/sun4i/sun4i_frontend.h
View File

@ -112,6 +112,10 @@ struct drm_plane;
struct regmap; struct regmap;
struct reset_control; struct reset_control;
struct sun4i_frontend_data {
bool has_coef_access_ctrl;
};
struct sun4i_frontend { struct sun4i_frontend {
struct list_head list; struct list_head list;
struct device *dev; struct device *dev;
@ -122,6 +126,8 @@ struct sun4i_frontend {
struct clk *ram_clk; struct clk *ram_clk;
struct regmap *regs; struct regmap *regs;
struct reset_control *reset; struct reset_control *reset;
const struct sun4i_frontend_data *data;
}; };
extern const struct of_device_id sun4i_frontend_of_table[]; extern const struct of_device_id sun4i_frontend_of_table[];