leandrof/linux
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

platform/x86: thinkpad_acpi: Use strndup_user() in dispatch_proc_write()

Browse Source 
Simplify the user copy code by using strndup_user().

Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
This commit is contained in:
Andy Shevchenko 2020-05-11 15:54:14 +03:00
parent be51bd4585
commit 35d13c7a05
1 changed files with 3 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
drivers/platform/x86/thinkpad_acpi.c
View File

@ -885,19 +885,11 @@ static ssize_t dispatch_proc_write(struct file *file,
if (!ibm || !ibm->write) if (!ibm || !ibm->write)
return -EINVAL; return -EINVAL;
if (count > PAGE_SIZE - 1)
return -EINVAL;
kernbuf = kmalloc(count + 1, GFP_KERNEL); kernbuf = strndup_user(userbuf, PAGE_SIZE);
if (!kernbuf) if (IS_ERR(kernbuf))
return -ENOMEM; return PTR_ERR(kernbuf);
if (copy_from_user(kernbuf, userbuf, count)) {
kfree(kernbuf);
return -EFAULT;
}
kernbuf[count] = 0;
ret = ibm->write(kernbuf); ret = ibm->write(kernbuf);
if (ret == 0) if (ret == 0)
ret = count; ret = count;