leandrof/linux
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

iwlwifi: fw: Replace zero-length arrays with flexible-array members

Browse Source 
There is a regular need in the kernel to provide a way to declare
having a dynamically sized set of trailing elements in a structure.
Kernel code should always use “flexible array members”[1] for these
cases. The older style of one-element or zero-length arrays should
no longer be used[2].

[1] https://en.wikipedia.org/wiki/Flexible_array_member
[2] https://www.kernel.org/doc/html/v5.16/process/deprecated.html#zero-length-and-one-element-arrays

Link: https://github.com/KSPP/linux/issues/78
Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org>
Reviewed-by: Kees Cook <keescook@chromium.org>
Acked-by: Luca Coelho <luciano.coelho@intel.com>
Signed-off-by: Kalle Valo <kvalo@kernel.org>
Link: https://lore.kernel.org/r/20220216195015.GA904148@embeddedor
This commit is contained in:
Gustavo A. R. Silva
2022-02-16 13:50:15 -06:00
committed by Kalle Valo
parent 0b5c21bbc0
commit 34e63cd5ba
8 changed files with 15 additions and 15 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
drivers/net/wireless/intel/iwlwifi/fw/api/dbg-tlv.h
View File

@@ -26,7 +26,7 @@ struct iwl_fw_ini_hcmd {
u8 id; u8 id;
u8 group; u8 group;
__le16 reserved; __le16 reserved;
u8 data[0]; u8 data[];
} __packed; /* FW_DEBUG_TLV_HCMD_DATA_API_S_VER_1 */ } __packed; /* FW_DEBUG_TLV_HCMD_DATA_API_S_VER_1 */
/** /**
@@ -275,7 +275,7 @@ struct iwl_fw_ini_conf_set_tlv {
__le32 time_point; __le32 time_point;
__le32 set_type; __le32 set_type;
__le32 addr_offset; __le32 addr_offset;
struct iwl_fw_ini_addr_val addr_val[0]; struct iwl_fw_ini_addr_val addr_val[];
} __packed; /* FW_TLV_DEBUG_CONFIG_SET_API_S_VER_1 */ } __packed; /* FW_TLV_DEBUG_CONFIG_SET_API_S_VER_1 */
/** /**

4
drivers/net/wireless/intel/iwlwifi/fw/api/debug.h
View File

@@ -240,7 +240,7 @@ struct iwl_mfu_assert_dump_notif {
__le16 index_num; __le16 index_num;
__le16 parts_num; __le16 parts_num;
__le32 data_size; __le32 data_size;
__le32 data[0]; __le32 data[];
} __packed; /* MFU_DUMP_ASSERT_API_S_VER_1 */ } __packed; /* MFU_DUMP_ASSERT_API_S_VER_1 */
/** /**
@@ -276,7 +276,7 @@ struct iwl_mvm_marker {
u8 marker_id; u8 marker_id;
__le16 reserved; __le16 reserved;
__le64 timestamp; __le64 timestamp;
__le32 metadata[0]; __le32 metadata[];
} __packed; /* MARKER_API_S_VER_1 */ } __packed; /* MARKER_API_S_VER_1 */
/** /**

2
drivers/net/wireless/intel/iwlwifi/fw/api/filter.h
View File

@@ -33,7 +33,7 @@ struct iwl_mcast_filter_cmd {
u8 pass_all; u8 pass_all;
u8 bssid[6]; u8 bssid[6];
u8 reserved[2]; u8 reserved[2];
u8 addr_list[0]; u8 addr_list[];
} __packed; /* MCAST_FILTERING_CMD_API_S_VER_1 */ } __packed; /* MCAST_FILTERING_CMD_API_S_VER_1 */
#endif /* __iwl_fw_api_filter_h__ */ #endif /* __iwl_fw_api_filter_h__ */

4
drivers/net/wireless/intel/iwlwifi/fw/api/scan.h
View File

@@ -1165,7 +1165,7 @@ struct iwl_scan_offload_profiles_query_v1 {
u8 resume_while_scanning; u8 resume_while_scanning;
u8 self_recovery; u8 self_recovery;
__le16 reserved; __le16 reserved;
struct iwl_scan_offload_profile_match_v1 matches[0]; struct iwl_scan_offload_profile_match_v1 matches[];
} __packed; /* SCAN_OFFLOAD_PROFILES_QUERY_RSP_S_VER_2 */ } __packed; /* SCAN_OFFLOAD_PROFILES_QUERY_RSP_S_VER_2 */
/** /**
@@ -1209,7 +1209,7 @@ struct iwl_scan_offload_profiles_query {
u8 resume_while_scanning; u8 resume_while_scanning;
u8 self_recovery; u8 self_recovery;
__le16 reserved; __le16 reserved;
struct iwl_scan_offload_profile_match matches[0]; struct iwl_scan_offload_profile_match matches[];
} __packed; /* SCAN_OFFLOAD_PROFILES_QUERY_RSP_S_VER_3 */ } __packed; /* SCAN_OFFLOAD_PROFILES_QUERY_RSP_S_VER_3 */
/** /**

2
drivers/net/wireless/intel/iwlwifi/fw/api/sta.h
View File

@@ -477,7 +477,7 @@ struct iwl_mvm_wep_key_cmd {
u8 decryption_type; u8 decryption_type;
u8 flags; u8 flags;
u8 reserved; u8 reserved;
struct iwl_mvm_wep_key wep_key[0]; struct iwl_mvm_wep_key wep_key[];
} __packed; /* SEC_CURR_WEP_KEY_CMD_API_S_VER_2 */ } __packed; /* SEC_CURR_WEP_KEY_CMD_API_S_VER_2 */
/** /**

2
drivers/net/wireless/intel/iwlwifi/fw/api/tdls.h
View File

@@ -132,7 +132,7 @@ struct iwl_tdls_config_cmd {
__le32 pti_req_data_offset; __le32 pti_req_data_offset;
struct iwl_tx_cmd pti_req_tx_cmd; struct iwl_tx_cmd pti_req_tx_cmd;
u8 pti_req_template[0]; u8 pti_req_template[];
} __packed; /* TDLS_CONFIG_CMD_API_S_VER_1 */ } __packed; /* TDLS_CONFIG_CMD_API_S_VER_1 */
/** /**

2
drivers/net/wireless/intel/iwlwifi/fw/error-dump.h
View File

@@ -84,7 +84,7 @@ struct iwl_fw_error_dump_data {
struct iwl_fw_error_dump_file { struct iwl_fw_error_dump_file {
__le32 barker; __le32 barker;
__le32 file_len; __le32 file_len;
u8 data[0]; u8 data[];
} __packed; } __packed;
/** /**

10
drivers/net/wireless/intel/iwlwifi/fw/file.h
View File

@@ -145,7 +145,7 @@ struct iwl_tlv_ucode_header {
* Note that each TLV is padded to a length * Note that each TLV is padded to a length
* that is a multiple of 4 for alignment. * that is a multiple of 4 for alignment.
*/ */
u8 data[0]; u8 data[];
}; };
/* /*
@@ -603,7 +603,7 @@ struct iwl_fw_dbg_dest_tlv_v1 {
__le32 wrap_count; __le32 wrap_count;
u8 base_shift; u8 base_shift;
u8 end_shift; u8 end_shift;
struct iwl_fw_dbg_reg_op reg_ops[0]; struct iwl_fw_dbg_reg_op reg_ops[];
} __packed; } __packed;
/* Mask of the register for defining the LDBG MAC2SMEM buffer SMEM size */ /* Mask of the register for defining the LDBG MAC2SMEM buffer SMEM size */
@@ -623,14 +623,14 @@ struct iwl_fw_dbg_dest_tlv {
__le32 wrap_count; __le32 wrap_count;
u8 base_shift; u8 base_shift;
u8 size_shift; u8 size_shift;
struct iwl_fw_dbg_reg_op reg_ops[0]; struct iwl_fw_dbg_reg_op reg_ops[];
} __packed; } __packed;
struct iwl_fw_dbg_conf_hcmd { struct iwl_fw_dbg_conf_hcmd {
u8 id; u8 id;
u8 reserved; u8 reserved;
__le16 len; __le16 len;
u8 data[0]; u8 data[];
} __packed; } __packed;
/** /**
@@ -705,7 +705,7 @@ struct iwl_fw_dbg_trigger_tlv {
u8 flags; u8 flags;
u8 reserved[5]; u8 reserved[5];
u8 data[0]; u8 data[];
} __packed; } __packed;
#define FW_DBG_START_FROM_ALIVE 0 #define FW_DBG_START_FROM_ALIVE 0