leandrof/linux
1
0
Fork 0
forked from Minki/linux
Code Issues Pull Requests Packages Projects Releases Wiki Activity

HID: magicmouse: Fix an error handling path in magicmouse_probe()

Browse Source 
If the timer introduced by the commit below is started, then it must be
deleted in the error handling of the probe. Otherwise it would trigger
once the driver is no more.

Fixes: 0b91b4e4da ("HID: magicmouse: Report battery level over USB")
Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Tested-by: José Expósito <jose.exposito89@gmail.com>
Reported-by: <syzbot+a437546ec71b04dfb5ac@syzkaller.appspotmail.com>
Signed-off-by: Jiri Kosina <jkosina@suse.cz>
This commit is contained in:
Christophe JAILLET 2021-12-28 22:09:17 +01:00 committed by Jiri Kosina
parent 0b91b4e4da
commit 33812fc7c8
1 changed files with 1 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
drivers/hid/hid-magicmouse.c
View File

@ -870,6 +870,7 @@ static int magicmouse_probe(struct hid_device *hdev,
return 0;
err_stop_hw:
del_timer_sync(&msc->battery_timer);
hid_hw_stop(hdev);
return ret;
}