leandrof/linux
1
0
Fork 0
forked from Minki/linux
Code Issues Pull Requests Packages Projects Releases Wiki Activity

[SCSI] libsas: don't use made up error codes

Browse Source 
This is bad for two reasons:

     1. If they're returned to outside applications, no-one knows what
        they mean.
     2. Eventually they'll clash with the ever expanding standard error
        codes.

The problem error code in question is ETASK.  I've replaced this by
ECOMM (communications error on send) a network error code that seems to
most closely relay what ETASK meant.

Acked-by: Darrick J. Wong <djwong@us.ibm.com>
Signed-off-by: James Bottomley <James.Bottomley@HansenPartnership.com>
This commit is contained in:
James Bottomley 2007-12-30 12:37:31 -06:00
parent 2d507a01da
commit 32e8ae36b8
3 changed files with 2 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
drivers/scsi/libsas/sas_ata.c
View File

@ -500,7 +500,7 @@ static int sas_execute_task(struct sas_task *task, void *buffer, int size,
goto ex_err; goto ex_err;
} }
wait_for_completion(&task->completion); wait_for_completion(&task->completion);
res = -ETASK; res = -ECOMM;
if (task->task_state_flags & SAS_TASK_STATE_ABORTED) { if (task->task_state_flags & SAS_TASK_STATE_ABORTED) {
int res2; int res2;
SAS_DPRINTK("task aborted, flags:0x%x\n", SAS_DPRINTK("task aborted, flags:0x%x\n",

2
drivers/scsi/libsas/sas_expander.c
View File

@ -96,7 +96,7 @@ static int smp_execute_task(struct domain_device *dev, void *req, int req_size,
} }
wait_for_completion(&task->completion); wait_for_completion(&task->completion);
res = -ETASK; res = -ECOMM;
if ((task->task_state_flags & SAS_TASK_STATE_ABORTED)) { if ((task->task_state_flags & SAS_TASK_STATE_ABORTED)) {
SAS_DPRINTK("smp task timed out or aborted\n"); SAS_DPRINTK("smp task timed out or aborted\n");
i->dft->lldd_abort_task(task); i->dft->lldd_abort_task(task);

2
include/scsi/libsas.h
View File

@ -91,8 +91,6 @@ enum discover_event {
/* ---------- Expander Devices ---------- */ /* ---------- Expander Devices ---------- */
#define ETASK 0xFA
#define to_dom_device(_obj) container_of(_obj, struct domain_device, dev_obj) #define to_dom_device(_obj) container_of(_obj, struct domain_device, dev_obj)
#define to_dev_attr(_attr) container_of(_attr, struct domain_dev_attribute,\ #define to_dev_attr(_attr) container_of(_attr, struct domain_dev_attribute,\
attr) attr)