leandrof/linux
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

libsymbols kallsyms: Move hex2u64 out of header

Browse Source 
hex2u64 is a helper that's out of place in kallsyms.h as not being
kallsyms related. Move from kallsyms.h to the only user.

Committer notes:

Move it out of tools/lib/symbol/kallsyms.c as well, as we had to leave
it there in the previous patch lest we break the build.

Signed-off-by: Ian Rogers <irogers@google.com>
Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com>
Cc: Jiri Olsa <jolsa@redhat.com>
Cc: Mark Rutland <mark.rutland@arm.com>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Stephane Eranian <eranian@google.com>
Cc: Thomas Gleixner <tglx@linutronix.de>
Link: http://lore.kernel.org/lkml/20200501221315.54715-4-irogers@google.com
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
This commit is contained in:
Ian Rogers
2020-05-01 15:13:15 -07:00
committed by Arnaldo Carvalho de Melo
parent 53df2b9344
commit 32add10f95
3 changed files with 14 additions and 15 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
tools/lib/symbol/kallsyms.c
View File

@@ -11,19 +11,6 @@ u8 kallsyms2elf_type(char type)
return (type == 't' || type == 'w') ? STT_FUNC : STT_OBJECT; return (type == 't' || type == 'w') ? STT_FUNC : STT_OBJECT;
} }
/*
* While we find nice hex chars, build a long_val.
* Return number of chars processed.
*/
int hex2u64(const char *ptr, u64 *long_val)
{
char *p;
*long_val = strtoull(ptr, &p, 16);
return p - ptr;
}
bool kallsyms__is_function(char symbol_type) bool kallsyms__is_function(char symbol_type)
{ {
symbol_type = toupper(symbol_type); symbol_type = toupper(symbol_type);

2
tools/lib/symbol/kallsyms.h
View File

@@ -18,8 +18,6 @@ static inline u8 kallsyms2elf_binding(char type)
return isupper(type) ? STB_GLOBAL : STB_LOCAL; return isupper(type) ? STB_GLOBAL : STB_LOCAL;
} }
int hex2u64(const char *ptr, u64 *long_val);
u8 kallsyms2elf_type(char type); u8 kallsyms2elf_type(char type);
bool kallsyms__is_function(char symbol_type); bool kallsyms__is_function(char symbol_type);

14
tools/perf/util/symbol.c
View File

@@ -566,6 +566,20 @@ void dso__sort_by_name(struct dso *dso)
return symbols__sort_by_name(&dso->symbol_names, &dso->symbols); return symbols__sort_by_name(&dso->symbol_names, &dso->symbols);
} }
/*
* While we find nice hex chars, build a long_val.
* Return number of chars processed.
*/
static int hex2u64(const char *ptr, u64 *long_val)
{
char *p;
*long_val = strtoull(ptr, &p, 16);
return p - ptr;
}
int modules__parse(const char *filename, void *arg, int modules__parse(const char *filename, void *arg,
int (*process_module)(void *arg, const char *name, int (*process_module)(void *arg, const char *name,
u64 start, u64 size)) u64 start, u64 size))