leandrof/linux
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

[media] dvb_usb_v2: do not free resources until delayed init is done

Browse Source 
It was possible to free resources by unloading module while
initialization was still ongoing on delayed work.

Use PID to make decision on .disconnect() if caller is our
work or some other as work also calls .disconnect() in error
case. There could be better solution still...

Signed-off-by: Antti Palosaari <crope@iki.fi>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
This commit is contained in:
Antti Palosaari 2012-06-09 21:11:28 -03:00 committed by Mauro Carvalho Chehab
parent 36a5c2bded
commit 3238aafbc3
2 changed files with 9 additions and 13 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
drivers/media/dvb/dvb-usb/dvb_usb.h
View File

@ -322,6 +322,7 @@ struct dvb_usb_device {
struct dvb_usb_rc rc;
struct usb_device *udev;
struct work_struct probe_work;
pid_t work_pid;
struct usb_interface *intf;
#define DVB_USB_STATE_INIT 0x000

21
drivers/media/dvb/dvb-usb/dvb_usb_init.c
View File

@ -266,10 +266,6 @@ int dvb_usb_device_power_ctrl(struct dvb_usb_device *d, int onoff)
return 0;
}
/*
* USB
*/
/*
* udev, which is used for the firmware downloading, requires we cannot
* block during module_init(). module_init() calls USB probe() which
@ -284,7 +280,9 @@ static void dvb_usbv2_init_work(struct work_struct *work)
container_of(work, struct dvb_usb_device, probe_work);
bool cold = false;
pr_debug("%s:\n", __func__);
d->work_pid = current->pid;
pr_debug("%s: work_pid=%d\n", __func__, d->work_pid);
if (d->props.size_of_priv) {
d->priv = kzalloc(d->props.size_of_priv, GFP_KERNEL);
@ -405,15 +403,12 @@ void dvb_usbv2_disconnect(struct usb_interface *intf)
struct dvb_usb_device *d = usb_get_intfdata(intf);
const char *name = "generic DVB-USB module";
pr_debug("%s:\n", __func__);
pr_debug("%s: pid=%d work_pid=%d\n", __func__, current->pid,
d->work_pid);
/*
* FIXME: We should ensure initialization work is finished
* until exit from this routine (cancel_work_sync / flush_work).
* Unfortunately usb_driver_release_interface() call finally goes
* here too and in that case we endup deadlock. How to perform
* operation conditionally only on disconned / unload?
*/
/* ensure initialization work is finished until release resources */
if (d->work_pid != current->pid)
cancel_work_sync(&d->probe_work);
usb_set_intfdata(intf, NULL);
if (d) {