leandrof/linux
1
0
Fork 0
forked from Minki/linux
Code Issues Pull Requests Packages Projects Releases Wiki Activity

staging: wlags49_h2: Fix use of skb after netif_rx

Browse Source 
This patch moves a call to netif_rx(skb) after a subsequent reference to
skb, because netif_rx may call kfree_skb via enqueue_to_backlog on its
argument.

This was found using the following semantic match.

// <smpl>
@@
expression skb, e,e1;
@@

(
 netif_rx(skb);
|
 netif_rx_ni(skb);
)
  ... when != skb = e
(
  skb = e1
|
* skb
)
// </smpl>

Signed-off-by: Himangi Saraogi <himangi774@gmail.com>
Acked-by: Julia Lawall <julia.lawall@lip6.fr>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
Himangi Saraogi 2014-06-21 20:34:09 +05:30 committed by Greg Kroah-Hartman
parent 7873311aed
commit 31cd921dea
1 changed files with 1 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
drivers/staging/wlags49_h2/wl_netdev.c
View File

@ -888,8 +888,6 @@ int wl_rx(struct net_device *dev)
GET_PACKET(skb->dev, skb, pktlen);
if (status == HCF_SUCCESS) {
netif_rx(skb);
if (port == 0) {
lp->stats.rx_packets++;
lp->stats.rx_bytes += pktlen;
@ -918,6 +916,7 @@ int wl_rx(struct net_device *dev)
}
#endif /* WIRELESS_SPY */
#endif /* WIRELESS_EXT */
netif_rx(skb);
} else {
DBG_ERROR(DbgInfo,
"Rx request to card FAILED\n");