leandrof/linux
1
0
Fork 0
forked from Minki/linux
Code Issues Pull Requests Packages Projects Releases Wiki Activity

crypto: rng - fix crypto_rng_reset() refcounting when !CRYPTO_STATS

Browse Source 
crypto_stats_get() is a no-op when the kernel is compiled without
CONFIG_CRYPTO_STATS, so pairing it with crypto_alg_put() unconditionally
(as crypto_rng_reset() does) is wrong.

Fix this by moving the call to crypto_stats_get() to just before the
actual algorithm operation which might need it.  This makes it always
paired with crypto_stats_rng_seed().

Fixes: eed74b3eba ("crypto: rng - Fix a refcounting bug in crypto_rng_reset()")
Cc: stable@vger.kernel.org
Signed-off-by: Eric Biggers <ebiggers@google.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
This commit is contained in:
Eric Biggers 2021-03-21 22:07:48 -07:00 committed by Herbert Xu
parent 10cb823bba
commit 30d0f6a956
1 changed files with 3 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
crypto/rng.c
View File

@ -34,22 +34,18 @@ int crypto_rng_reset(struct crypto_rng *tfm, const u8 *seed, unsigned int slen)
u8 *buf = NULL; u8 *buf = NULL;
int err; int err;
crypto_stats_get(alg);
if (!seed && slen) { if (!seed && slen) {
buf = kmalloc(slen, GFP_KERNEL); buf = kmalloc(slen, GFP_KERNEL);
if (!buf) { if (!buf)
crypto_alg_put(alg);
return -ENOMEM; return -ENOMEM;
}
err = get_random_bytes_wait(buf, slen); err = get_random_bytes_wait(buf, slen);
if (err) { if (err)
crypto_alg_put(alg);
goto out; goto out;
}
seed = buf; seed = buf;
} }
crypto_stats_get(alg);
err = crypto_rng_alg(tfm)->seed(tfm, seed, slen); err = crypto_rng_alg(tfm)->seed(tfm, seed, slen);
crypto_stats_rng_seed(alg, err); crypto_stats_rng_seed(alg, err);
out: out: