leandrof/linux
1
0
Fork 0
forked from Minki/linux
Code Issues Pull Requests Packages Projects Releases Wiki Activity

staging: goldfish: Clear audio read buffer status after each read

Browse Source 
The buffer_status field is interrupt updated. After every read request,
the buffer_status read field should be reset so that on the next loop
iteration we don't read a stale value and read data before the
device is ready.

Signed-off-by: Joshua Lang <joshualang@google.com>
Signed-off-by: Roman Kiryanov <rkir@google.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
Joshua Lang 2018-06-04 14:08:22 -07:00 committed by Greg Kroah-Hartman
parent 06e526f49b
commit 3053339b17
1 changed files with 5 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
drivers/staging/goldfish/goldfish_audio.c
View File

@ -131,6 +131,7 @@ static ssize_t goldfish_audio_read(struct file *fp, char __user *buf,
size_t count, loff_t *pos)
{
struct goldfish_audio *data = fp->private_data;
unsigned long irq_flags;
int length;
int result = 0;
@ -144,6 +145,10 @@ static ssize_t goldfish_audio_read(struct file *fp, char __user *buf,
wait_event_interruptible(data->wait, data->buffer_status &
AUDIO_INT_READ_BUFFER_FULL);
spin_lock_irqsave(&data->lock, irq_flags);
data->buffer_status &= ~AUDIO_INT_READ_BUFFER_FULL;
spin_unlock_irqrestore(&data->lock, irq_flags);
length = audio_read(data, AUDIO_READ_BUFFER_AVAILABLE);
/* copy data to user space */