leandrof/linux
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

media: vsp1: Rename dl_child to dl_next

Browse Source 
Both vsp1_dl_list_commit() and __vsp1_dl_list_put() walk the display
list chain referencing the nodes as children, when in reality they are
siblings.

Update the terminology to 'dl_next' to be consistent with the
vsp1_video_pipeline_run() usage.

Signed-off-by: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>
Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab+samsung@kernel.org>
This commit is contained in:
Kieran Bingham 2018-08-03 07:37:22 -04:00 committed by Mauro Carvalho Chehab
parent 3e737e3943
commit 2ca72570b9
1 changed files with 7 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
drivers/media/platform/vsp1/vsp1_dl.c
View File

@ -399,7 +399,7 @@ struct vsp1_dl_list *vsp1_dl_list_get(struct vsp1_dl_manager *dlm)
/* This function must be called with the display list manager lock held.*/ /* This function must be called with the display list manager lock held.*/
static void __vsp1_dl_list_put(struct vsp1_dl_list *dl) static void __vsp1_dl_list_put(struct vsp1_dl_list *dl)
{ {
struct vsp1_dl_list *dl_child; struct vsp1_dl_list *dl_next;
if (!dl) if (!dl)
return; return;
@ -409,8 +409,8 @@ static void __vsp1_dl_list_put(struct vsp1_dl_list *dl)
* hardware operation. * hardware operation.
*/ */
if (dl->has_chain) { if (dl->has_chain) {
list_for_each_entry(dl_child, &dl->chain, chain) list_for_each_entry(dl_next, &dl->chain, chain)
__vsp1_dl_list_put(dl_child); __vsp1_dl_list_put(dl_next);
} }
dl->has_chain = false; dl->has_chain = false;
@ -674,17 +674,17 @@ static void vsp1_dl_list_commit_singleshot(struct vsp1_dl_list *dl)
void vsp1_dl_list_commit(struct vsp1_dl_list *dl, bool internal) void vsp1_dl_list_commit(struct vsp1_dl_list *dl, bool internal)
{ {
struct vsp1_dl_manager *dlm = dl->dlm; struct vsp1_dl_manager *dlm = dl->dlm;
struct vsp1_dl_list *dl_child; struct vsp1_dl_list *dl_next;
unsigned long flags; unsigned long flags;
if (dlm->mode == VSP1_DL_MODE_HEADER) { if (dlm->mode == VSP1_DL_MODE_HEADER) {
/* Fill the header for the head and chained display lists. */ /* Fill the header for the head and chained display lists. */
vsp1_dl_list_fill_header(dl, list_empty(&dl->chain)); vsp1_dl_list_fill_header(dl, list_empty(&dl->chain));
list_for_each_entry(dl_child, &dl->chain, chain) { list_for_each_entry(dl_next, &dl->chain, chain) {
bool last = list_is_last(&dl_child->chain, &dl->chain); bool last = list_is_last(&dl_next->chain, &dl->chain);
vsp1_dl_list_fill_header(dl_child, last); vsp1_dl_list_fill_header(dl_next, last);
} }
} }