leandrof/linux
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

staging: typec: fusb302: do not free gpio from managed resource

Browse Source 
When allocating a gpio using the managed resource devm_, we can avoid freeing it
manually. But even if we did it we should use devm_gpio_free.

So, just remove the free of the gpio in the error path.

Signed-off-by: Rui Miguel Silva <rmfrfs@gmail.com>
Acked-by: Yueyao Zhu <yueyao.zhu@gmail.com>
Reviewed-by: Guenter Roeck <linux@roeck-us.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
Rui Miguel Silva 2017-05-12 21:16:13 +01:00 committed by Greg Kroah-Hartman
parent 050161ea32
commit 2c8e3f44f7
1 changed files with 0 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
drivers/staging/typec/fusb302/fusb302.c
View File

@ -1663,14 +1663,12 @@ static int init_gpio(struct fusb302_chip *chip)
if (ret < 0) { if (ret < 0) {
fusb302_log(chip, fusb302_log(chip,
"cannot set GPIO Int_N to input, ret=%d", ret); "cannot set GPIO Int_N to input, ret=%d", ret);
gpio_free(chip->gpio_int_n);
return ret; return ret;
} }
ret = gpio_to_irq(chip->gpio_int_n); ret = gpio_to_irq(chip->gpio_int_n);
if (ret < 0) { if (ret < 0) {
fusb302_log(chip, fusb302_log(chip,
"cannot request IRQ for GPIO Int_N, ret=%d", ret); "cannot request IRQ for GPIO Int_N, ret=%d", ret);
gpio_free(chip->gpio_int_n);
return ret; return ret;
} }
chip->gpio_int_n_irq = ret; chip->gpio_int_n_irq = ret;