leandrof/linux
1
0
Fork 0
forked from Minki/linux
Code Issues Pull Requests Packages Projects Releases Wiki Activity

tracing/osnoise: Use start/stop_per_cpu_kthreads() on osnoise_cpus_write()

Browse Source 
When writing a new CPU mask via osnoise/cpus, if the tracer is running,
the workload is restarted to follow the new cpumask. The restart is
currently done using osnoise_workload_start/stop(), which disables the
workload *and* the instrumentation. However, disabling the
instrumentation is not necessary.

Calling start/stop_per_cpu_kthreads() is enough to apply the new
osnoise/cpus config.

Link: https://lkml.kernel.org/r/ee633e82867c5b88851aa6040522a799c0034486.1635702894.git.bristot@kernel.org

Cc: Ingo Molnar <mingo@redhat.com>
Cc: Tom Zanussi <zanussi@kernel.org>
Cc: Masami Hiramatsu <mhiramat@kernel.org>
Cc: Juri Lelli <juri.lelli@redhat.com>
Cc: Clark Williams <williams@redhat.com>
Cc: John Kacur <jkacur@redhat.com>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Cc: Daniel Bristot de Oliveira <bristot@kernel.org>
Cc: linux-rt-users@vger.kernel.org
Cc: linux-trace-devel@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
Signed-off-by: Daniel Bristot de Oliveira <bristot@kernel.org>
Signed-off-by: Steven Rostedt (VMware) <rostedt@goodmis.org>
This commit is contained in:
Daniel Bristot de Oliveira 2021-10-31 19:04:59 +01:00 committed by Steven Rostedt (VMware)
parent 15ca4bdb03
commit 2bd1bdf01f
1 changed files with 2 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
kernel/trace/trace_osnoise.c
View File

@ -1678,9 +1678,6 @@ out_unlock:
return count; return count;
} }
static int osnoise_workload_start(void);
static void osnoise_workload_stop(void);
/* /*
* osnoise_cpus_write - Write function for "cpus" entry * osnoise_cpus_write - Write function for "cpus" entry
* @filp: The active open file structure * @filp: The active open file structure
@ -1725,7 +1722,7 @@ osnoise_cpus_write(struct file *filp, const char __user *ubuf, size_t count,
mutex_lock(&trace_types_lock); mutex_lock(&trace_types_lock);
running = osnoise_busy; running = osnoise_busy;
if (running) if (running)
osnoise_workload_stop(); stop_per_cpu_kthreads();
mutex_lock(&interface_lock); mutex_lock(&interface_lock);
/* /*
@ -1739,7 +1736,7 @@ osnoise_cpus_write(struct file *filp, const char __user *ubuf, size_t count,
mutex_unlock(&interface_lock); mutex_unlock(&interface_lock);
if (running) if (running)
osnoise_workload_start(); start_per_cpu_kthreads();
mutex_unlock(&trace_types_lock); mutex_unlock(&trace_types_lock);
free_cpumask_var(osnoise_cpumask_new); free_cpumask_var(osnoise_cpumask_new);