leandrof/linux
1
0
Fork 0
forked from Minki/linux
Code Issues Pull Requests Packages Projects Releases Wiki Activity

fs/ncpfs/inode.c: suppress used-uninitialised warning

Browse Source 
We get this spurious warning:

  fs/ncpfs/inode.c: In function 'ncp_fill_super':
  fs/ncpfs/inode.c:451: warning: 'data.mounted_vol[1u]' may be used uninitialized in this function
  fs/ncpfs/inode.c:451: warning: 'data.mounted_vol[2u]' may be used uninitialized in this function
  fs/ncpfs/inode.c:451: warning: 'data.mounted_vol[3u]' may be used uninitialized in this function
  ...

It's notabug, but we can easily fix it with a memset().

Reported-by: Harry Wei <jiaweiwei.xiyou@gmail.com>
Cc: Petr Vandrovec <petr@vandrovec.name>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
This commit is contained in:
Andrew Morton 2011-05-24 17:13:42 -07:00 committed by Linus Torvalds
parent 0fccc62218
commit 2a5cac17c0
1 changed files with 1 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
fs/ncpfs/inode.c
View File

@ -461,7 +461,7 @@ static int ncp_fill_super(struct super_block *sb, void *raw_data, int silent)
#endif #endif
struct ncp_entry_info finfo; struct ncp_entry_info finfo;
data.wdog_pid = NULL; memset(&data, 0, sizeof(data));
server = kzalloc(sizeof(struct ncp_server), GFP_KERNEL); server = kzalloc(sizeof(struct ncp_server), GFP_KERNEL);
if (!server) if (!server)
return -ENOMEM; return -ENOMEM;
@ -496,7 +496,6 @@ static int ncp_fill_super(struct super_block *sb, void *raw_data, int silent)
struct ncp_mount_data_v4* md = (struct ncp_mount_data_v4*)raw_data; struct ncp_mount_data_v4* md = (struct ncp_mount_data_v4*)raw_data;
data.flags = md->flags; data.flags = md->flags;
data.int_flags = 0;
data.mounted_uid = md->mounted_uid; data.mounted_uid = md->mounted_uid;
data.wdog_pid = find_get_pid(md->wdog_pid); data.wdog_pid = find_get_pid(md->wdog_pid);
data.ncp_fd = md->ncp_fd; data.ncp_fd = md->ncp_fd;
@ -507,7 +506,6 @@ static int ncp_fill_super(struct super_block *sb, void *raw_data, int silent)
data.file_mode = md->file_mode; data.file_mode = md->file_mode;
data.dir_mode = md->dir_mode; data.dir_mode = md->dir_mode;
data.info_fd = -1; data.info_fd = -1;
data.mounted_vol[0] = 0;
} }
break; break;
default: default: