leandrof/linux
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

isdn: hfc_usb: Fix read buffer overflow

Browse Source 
Check whether index is within bounds before testing the element.

Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
Cc: Karsten Keil <isdn@linux-pingi.de>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
Roel Kluin 2009-11-04 08:31:59 -08:00 committed by David S. Miller
parent a947c8f031
commit 286e633ef0
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
drivers/isdn/hisax/hfc_usb.c
View File

@ -817,8 +817,8 @@ collect_rx_frame(usb_fifo * fifo, __u8 * data, int len, int finish)
} }
/* we have a complete hdlc packet */ /* we have a complete hdlc packet */
if (finish) { if (finish) {
if ((!fifo->skbuff->data[fifo->skbuff->len - 1]) if (fifo->skbuff->len > 3 &&
&& (fifo->skbuff->len > 3)) { !fifo->skbuff->data[fifo->skbuff->len - 1]) {
if (fifon == HFCUSB_D_RX) { if (fifon == HFCUSB_D_RX) {
DBG(HFCUSB_DBG_DCHANNEL, DBG(HFCUSB_DBG_DCHANNEL,