leandrof/linux
1
0
Fork 0
forked from Minki/linux
Code Issues Pull Requests Packages Projects Releases Wiki Activity

[POWERPC] spusched: Fix runqueue corruption

Browse Source 
spu_activate can be called from multiple threads at the same time on
behalf of the same spu context.  We need to make sure to only add it
once to avoid runqueue corruption.

Signed-off-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
Signed-off-by: Paul Mackerras <paulus@samba.org>
This commit is contained in:
Christoph Hellwig 2007-06-29 10:58:06 +10:00 committed by Paul Mackerras
parent c77239b8be
commit 27449971e6
1 changed files with 28 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

37
arch/powerpc/platforms/cell/spufs/sched.c
View File

@ -292,12 +292,25 @@ static void spu_unbind_context(struct spu *spu, struct spu_context *ctx)
*/ */
static void __spu_add_to_rq(struct spu_context *ctx) static void __spu_add_to_rq(struct spu_context *ctx)
{ {
int prio = ctx->prio; /*
* Unfortunately this code path can be called from multiple threads
list_add_tail(&ctx->rq, &spu_prio->runq[prio]); * on behalf of a single context due to the way the problem state
set_bit(prio, spu_prio->bitmap); * mmap support works.
if (!spu_prio->nr_waiting++) *
__mod_timer(&spusched_timer, jiffies + SPUSCHED_TICK); * Fortunately we need to wake up all these threads at the same time
* and can simply skip the runqueue addition for every but the first
* thread getting into this codepath.
*
* It's still quite hacky, and long-term we should proxy all other
* threads through the owner thread so that spu_run is in control
* of all the scheduling activity for a given context.
*/
if (list_empty(&ctx->rq)) {
list_add_tail(&ctx->rq, &spu_prio->runq[ctx->prio]);
set_bit(ctx->prio, spu_prio->bitmap);
if (!spu_prio->nr_waiting++)
__mod_timer(&spusched_timer, jiffies + SPUSCHED_TICK);
}
} }
static void __spu_del_from_rq(struct spu_context *ctx) static void __spu_del_from_rq(struct spu_context *ctx)
@ -440,12 +453,18 @@ int spu_activate(struct spu_context *ctx, unsigned long flags)
{ {
spuctx_switch_state(ctx, SPUCTX_UTIL_SYSTEM); spuctx_switch_state(ctx, SPUCTX_UTIL_SYSTEM);
if (ctx->spu)
return 0;
do { do {
struct spu *spu; struct spu *spu;
/*
* If there are multiple threads waiting for a single context
* only one actually binds the context while the others will
* only be able to acquire the state_mutex once the context
* already is in runnable state.
*/
if (ctx->spu)
return 0;
spu = spu_get_idle(ctx); spu = spu_get_idle(ctx);
/* /*
* If this is a realtime thread we try to get it running by * If this is a realtime thread we try to get it running by