leandrof/linux
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

RDMA: Fix return code check in rdma_set_cq_moderation

Browse Source 
The proper return code is "-EOPNOTSUPP" when the modify_cq() callback is
not supported, all drivers should generate this and all users should check
for it when detecting not supported functionality.

Signed-off-by: Kamal Heib <kamalheib1@gmail.com>
Acked-by: Leon Romanovsky <leonro@mellanox.com> (for mlx5)
Signed-off-by: Jason Gunthorpe <jgg@mellanox.com>
This commit is contained in:
Kamal Heib 2018-07-31 09:02:36 +03:00 committed by Jason Gunthorpe
parent dd708e7b45
commit 26e551c5ae
2 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
drivers/infiniband/hw/mlx5/cq.c
View File

@ -1184,7 +1184,7 @@ int mlx5_ib_modify_cq(struct ib_cq *cq, u16 cq_count, u16 cq_period)
int err; int err;
if (!MLX5_CAP_GEN(dev->mdev, cq_moderation)) if (!MLX5_CAP_GEN(dev->mdev, cq_moderation))
return -ENOSYS; return -EOPNOTSUPP;
if (cq_period > MLX5_MAX_CQ_PERIOD) if (cq_period > MLX5_MAX_CQ_PERIOD)
return -EINVAL; return -EINVAL;

2
drivers/infiniband/ulp/ipoib/ipoib_ethtool.c
View File

@ -102,7 +102,7 @@ static int ipoib_set_coalesce(struct net_device *dev,
ret = rdma_set_cq_moderation(priv->recv_cq, ret = rdma_set_cq_moderation(priv->recv_cq,
coal->rx_max_coalesced_frames, coal->rx_max_coalesced_frames,
coal->rx_coalesce_usecs); coal->rx_coalesce_usecs);
if (ret && ret != -ENOSYS) { if (ret && ret != -EOPNOTSUPP) {
ipoib_warn(priv, "failed modifying CQ (%d)\n", ret); ipoib_warn(priv, "failed modifying CQ (%d)\n", ret);
return ret; return ret;
} }